Skip to content

don't update storage mtime if we can't get the modified date #25005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PVince81 merged 2 commits into from
Jun 8, 2016
Merged

don't update storage mtime if we can't get the modified date #25005

PVince81 merged 2 commits into from
Jun 8, 2016

Conversation

@icewind1991
Copy link
Contributor

@icewind1991 icewind1991 commented Jun 7, 2016

if a file doesn't exist, filemtime will return false

Error is caused by trying to delete a ghost file since #24813

Fixes #25002

@icewind1991 icewind1991 added this to the 9.1-current milestone Jun 7, 2016
@mention-bot
Copy link

mention-bot commented Jun 7, 2016

By analyzing the blame information on this pull request, we identified @d--j, @PVince81 and @schiessle to be potential reviewers

@icewind1991 icewind1991 force-pushed the parent-storage-time-cast branch from 8da966b to 6822689 Compare June 7, 2016 13:04
@icewind1991 icewind1991 mentioned this pull request Jun 7, 2016
Closed
@nickvergessen
Copy link
Contributor

nickvergessen commented Jun 7, 2016

Should fix both, oracle and postgres: 👍

@PVince81
Copy link
Contributor

PVince81 commented Jun 7, 2016

👍

@PVince81
Copy link
Contributor

PVince81 commented Jun 7, 2016

pgsql not behaving:

09:18:10 + phpenv local 5.6
09:18:10 /tmp/hudson9176260981587050817.sh: 2: /tmp/hudson9176260981587050817.sh: phpenv: not found
09:18:11 Build step 'Execute shell' marked build as failure
09:18:11 Recording test results
09:18:13 ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error?
09:18:13 Setting commit status on GitHub for https://github.com/owncloud/core/commit/6822689e381b12df035384b6b25ff8d07e6b57a3
09:18:13 Finished: FAILURE

OCI broken:

09:18:10 + phpenv local 5.6
09:18:10 /tmp/hudson9176260981587050817.sh: 2: /tmp/hudson9176260981587050817.sh: phpenv: not found
09:18:11 Build step 'Execute shell' marked build as failure
09:18:11 Recording test results
09:18:13 ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error?
09:18:13 Setting commit status on GitHub for https://github.com/owncloud/core/commit/6822689e381b12df035384b6b25ff8d07e6b57a3
09:18:13 Finished: FAILURE

@icewind1991 I didn't expect your PR to have such side effects.

@icewind1991
Copy link
Contributor Author

icewind1991 commented Jun 7, 2016

jenkins seems to have exploded a bit from what I can tell (same errors in #24899)

@nickvergessen
Copy link
Contributor

nickvergessen commented Jun 7, 2016

Oracle tests seem to fail normally, dont know where you looked:

15:54:24 1) Test\Files\ViewTest::testLockBasicOperation with data set #20 ('file_exists', array('dir'), 'dir', null)
15:54:24 Doctrine\DBAL\Exception\NotNullConstraintViolationException: An exception occurred while executing 'INSERT INTO "oc_filecache" ("mimepart","mimetype","mtime","size","etag","storage_mtime","permissions","checksum","path_hash","path","parent","name","storage") SELECT ?,?,?,?,?,?,?,?,?,?,?,?,? FROM "oc_filecache" WHERE "storage" = ? AND "path_hash" = ? HAVING COUNT(*) = 0' with params ["1", "2", false, -1, "5756ccac8f269", false, 23, "", "d41d8cd98f00b204e9800998ecf8427e", "", -1, "", 921, 921, "d41d8cd98f00b204e9800998ecf8427e"]:
15:54:24 
15:54:24 ORA-01400: cannot insert NULL into ("AUTOTEST"."oc_filecache"."mtime")
15:54:24 
15:54:24 /ssd/jenkins/workspace/core-ci-linux/database/oci/label/SLAVE/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/AbstractOracleDriver.php:68
15:54:24 /ssd/jenkins/workspace/core-ci-linux/database/oci/label/SLAVE/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php:116
15:54:24 /ssd/jenkins/workspace/core-ci-linux/database/oci/label/SLAVE/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:996
15:54:24 /ssd/jenkins/workspace/core-ci-linux/database/oci/label/SLAVE/lib/private/DB/Connection.php:209
15:54:24 /ssd/jenkins/workspace/core-ci-linux/database/oci/label/SLAVE/lib/private/DB/Adapter.php:113
15:54:24 /ssd/jenkins/workspace/core-ci-linux/database/oci/label/SLAVE/lib/private/DB/Connection.php:247
15:54:24 /ssd/jenkins/workspace/core-ci-linux/database/oci/label/SLAVE/lib/private/Files/Cache/Cache.php:265
15:54:24 /ssd/jenkins/workspace/core-ci-linux/database/oci/label/SLAVE/lib/private/Files/Cache/Cache.php:220
15:54:24 /ssd/jenkins/workspace/core-ci-linux/database/oci/label/SLAVE/lib/private/Files/Cache/Scanner.php:261
15:54:24 /ssd/jenkins/workspace/core-ci-linux/database/oci/label/SLAVE/lib/private/Files/Cache/Scanner.php:201
15:54:24 /ssd/jenkins/workspace/core-ci-linux/database/oci/label/SLAVE/lib/private/Files/Cache/Scanner.php:163
15:54:24 /ssd/jenkins/workspace/core-ci-linux/database/oci/label/SLAVE/lib/private/Files/Cache/Scanner.php:304
15:54:24 /ssd/jenkins/workspace/core-ci-linux/database/oci/label/SLAVE/tests/lib/Files/ViewTest.php:1773

15:54:24 2) Test\Files\ViewTest::testLockBasicOperationUnlocksAfterException with data set #20 ('file_exists', array('dir'), 'dir', null)
15:54:24 Doctrine\DBAL\Exception\NotNullConstraintViolationException: An exception occurred while executing 'INSERT INTO "oc_filecache" ("mimepart","mimetype","mtime","size","etag","storage_mtime","permissions","checksum","path_hash","path","parent","name","storage") SELECT ?,?,?,?,?,?,?,?,?,?,?,?,? FROM "oc_filecache" WHERE "storage" = ? AND "path_hash" = ? HAVING COUNT(*) = 0' with params ["1", "2", false, -1, "5756ccba82c57", false, 23, "", "d41d8cd98f00b204e9800998ecf8427e", "", -1, "", 968, 968, "d41d8cd98f00b204e9800998ecf8427e"]:
15:54:24 
15:54:24 ORA-01400: cannot insert NULL into ("AUTOTEST"."oc_filecache"."mtime")
15:54:24 
15:54:24 /ssd/jenkins/workspace/core-ci-linux/database/oci/label/SLAVE/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Driver/AbstractOracleDriver.php:68
15:54:24 /ssd/jenkins/workspace/core-ci-linux/database/oci/label/SLAVE/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php:116
15:54:24 /ssd/jenkins/workspace/core-ci-linux/database/oci/label/SLAVE/3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:996
15:54:24 /ssd/jenkins/workspace/core-ci-linux/database/oci/label/SLAVE/lib/private/DB/Connection.php:209
15:54:24 /ssd/jenkins/workspace/core-ci-linux/database/oci/label/SLAVE/lib/private/DB/Adapter.php:113
15:54:24 /ssd/jenkins/workspace/core-ci-linux/database/oci/label/SLAVE/lib/private/DB/Connection.php:247
15:54:24 /ssd/jenkins/workspace/core-ci-linux/database/oci/label/SLAVE/lib/private/Files/Cache/Cache.php:265
15:54:24 /ssd/jenkins/workspace/core-ci-linux/database/oci/label/SLAVE/lib/private/Files/Cache/Cache.php:220
15:54:24 /ssd/jenkins/workspace/core-ci-linux/database/oci/label/SLAVE/lib/private/Files/Cache/Scanner.php:261
15:54:24 /ssd/jenkins/workspace/core-ci-linux/database/oci/label/SLAVE/lib/private/Files/Cache/Scanner.php:201
15:54:24 /ssd/jenkins/workspace/core-ci-linux/database/oci/label/SLAVE/lib/private/Files/Cache/Scanner.php:163
15:54:24 /ssd/jenkins/workspace/core-ci-linux/database/oci/label/SLAVE/lib/private/Files/Cache/Scanner.php:304
15:54:24 /ssd/jenkins/workspace/core-ci-linux/database/oci/label/SLAVE/tests/lib/Files/ViewTest.php:1911

@nickvergessen
Copy link
Contributor

nickvergessen commented Jun 7, 2016

We use false here instead of taking care that it is int only:

core/lib/private/Files/Storage/Common.php

Line 645 in aba5397

$data['mtime'] = $this->filemtime($path);

@nickvergessen
Copy link
Contributor

nickvergessen commented Jun 8, 2016

👍 all green again

@nickvergessen
Copy link
Contributor

nickvergessen commented Jun 8, 2016

@PVince81 your +1 still counts?

@PVince81
Copy link
Contributor

PVince81 commented Jun 8, 2016

Yes... and I pray that these changes won't cause further side effects down the road.

@PVince81 PVince81 merged commit 87c150e into master Jun 8, 2016
@PVince81 PVince81 deleted the parent-storage-time-cast branch June 8, 2016 07:57
@lock
Copy link

lock bot commented Aug 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

3 - To Review dev:phpunit-tests sev1-critical

Projects

None yet

Milestone

9.1

Development

Successfully merging this pull request may close these issues.

[CI] postgres on master is failing

5 participants

@icewind1991 @mention-bot @nickvergessen @PVince81