files_external: Keep checkbox and its label on one line

[guruz]

Else the checkbox and the decription end up on different lines in my Chrome on OS X

I only saw the settings.js executed, not the PHP. Can anyone tell me where/how the PHP part is used?

[mention-bot]

By analyzing the blame information on this pull request, we identified @icewind1991, @PVince81 and @Xenopathic to be potential reviewers

[PVince81]

@guruz the PHP part might be executed when reloading the page with existing configs.

Ideally in the future all should be rendered in JS only... legacy stuff

Looks good

[PVince81]

Okay, I tried it properly with Amazon S3 and "Enable SSL".

It seems that on master the checkbox value is properly kept on refresh.
But when I switch to your branch, the checkbox isn't ticked any more.

Can you check whether there are other places in the code where the jquery selector might be too specific ?

[guruz]

Should be better now.

I tried improving the alignment a bit more but failed. Seems to be a major PITA https://stackoverflow.com/questions/306252/how-to-align-checkboxes-and-their-labels-consistently-cross-browsers

Maybe something for a followup

[PVince81]

Looks good and checkbox value is kept on refresh 👍

Second review @icewind1991 @Xenopathic @jvillafanez ?

[jvillafanez]

Looks good 👍

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.