Fix "Other" value handling in quota dropdown in users page

[PVince81]

Prevents "other" value to be deleted.
When appending custom value, put it above the "other" entry.

Fixes #24664

Please review @owncloud/javascript @icewind1991 @guruz @georgehrke @SergioBertolinSG @humblemumble

• TEST: select "Other", leave field without entering, reopen dropdown: dropdown looks sane
• TEST: select "Other", enter value. Value properly selected in dropdown (before/after page refresh)
• TEST: custom quota appears above "Other" in dropdown (before/after page refresh)

[mention-bot]

By analyzing the blame information on this pull request, we identified @MorrisJobke, @ringmaster and @blizzz to be potential reviewers

[SergioBertolinSG]

Entering non numbers makes it put a quote of 'B'. Entering negative numbers put a quote of '?'.
Those values should be not allowed. (return to default value instead would be better)

[PVince81]

@SergioBertolinSG ok, I added some crude validation to make you happy. Please try again.

[SergioBertolinSG]

A couple of remaining cases:
A number divided by zero like "600/0" puts 'B' in the dropdown.
Using float numbers with comma instead of dot puts 'B' as well. (avoid that format or allow it)

[PVince81]

I didn't intend this PR to be about validation, but ok let me try and make the validation slightly better.
I do not want to write a parser that checks for the MB/GB value here.

[SergioBertolinSG]

I think just avoiding those 'B' values and not allow number/0 and XX,XX format can be enough for now.

[guruz]

👍
Tested a bit, seems to work.

[PVince81]

@SergioBertolinSG the problem is as follows:

The user can enter values like "123", "123MB" or "123 MB".
Basically it's a number probably followed by letters.

So far I just used parseInt(quota, 10) which can detect whether there is at least a number at the beginning and ignore the letters.

But now if you type "1/0" it also passes the test because it starts with a number.

If we want to make it accurate, we need to develop a regexp that matches the expected formats. I wanted to avoid going that far in this quick fix. Also I don't think people would enter such strange values by mistake.

[SergioBertolinSG]

Float numbers using comma are very likely to be introduced by people using translated setups.
Anyway I'm fine with merging this and open an issue about improving that validation with a regexp as an enhancement.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.