[stable9.1] Add all properties while creating a subscription #25335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @nickvergessen, @LukasReschke, @stweil and @DeepDiver1975 to be potential reviewers |
DeepDiver1975
changed the title
Contributor
|
not critical -> 9.1.1 |
Member
Author
|
@georgehrke @PVince81 mind testing/review? THX |
Contributor
|
👍 |
| $values[$dbName] = $properties[$xmlName]; | ||
| if (in_array($dbName, $propertiesBoolean)) { | ||
| $values[$dbName] = true; | ||
| } |
Contributor
|
Code looks good otherwise 👍 |
DeepDiver1975
force-pushed
the
add-all-properties-create-subscription-stable9.1
branch
from
0a3c755 to
ede538f
Compare
Member
Author
|
indent fixed -> merge |
DeepDiver1975
deleted the
add-all-properties-create-subscription-stable9.1
branch
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #25318
Fixes #24469