Skip to content

[stable9] fix ldap:check-user command / User Cleanup does not work #25338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DeepDiver1975 merged 1 commit into from
Jul 4, 2016
Merged

[stable9] fix ldap:check-user command / User Cleanup does not work #25338

DeepDiver1975 merged 1 commit into from
Jul 4, 2016

Conversation

@felixboehm
Copy link
Contributor

@felixboehm felixboehm commented Jul 1, 2016 •
edited
Loading

@mention-bot
Copy link

mention-bot commented Jul 1, 2016

By analyzing the blame information on this pull request, we identified @blizzz, @MorrisJobke and @dschmidt to be potential reviewers

@felixboehm felixboehm added this to the 9.0.4 milestone Jul 1, 2016
@PVince81
Copy link
Contributor

PVince81 commented Jul 1, 2016

@owncloud/ldap @DeepDiver1975

@felixboehm please note that in general PRs have to be submitted against master and backported afterwards.

After reviewing this PR will need to submit PRs for stable9.1 and master too.

@PVince81
Copy link
Contributor

PVince81 commented Jul 1, 2016

@owncloud/qa can you help testing this ? Also check if previous versions are affected.

@SergioBertolinSG
Copy link
Contributor

SergioBertolinSG commented Jul 4, 2016

Works 👍

@DeepDiver1975
Copy link
Member

DeepDiver1975 commented Jul 4, 2016

👍

@DeepDiver1975 DeepDiver1975 merged commit fdb0d4a into stable9 Jul 4, 2016
@DeepDiver1975 DeepDiver1975 deleted the stable9-fix-ldap-check-user branch July 4, 2016 12:16
@PVince81
Copy link
Contributor

PVince81 commented Jul 4, 2016

Requires PRs for stable9.1 and master

@DeepDiver1975 DeepDiver1975 self-assigned this Jul 4, 2016
@DeepDiver1975
Copy link
Member

DeepDiver1975 commented Jul 4, 2016

Requires PRs for stable9.1 and master

on it

@PVince81
Copy link
Contributor

PVince81 commented Jul 4, 2016

We might also want to backport to 8.2 ? (depending when that command was introduced)

DeepDiver1975 pushed a commit that referenced this pull request Jul 4, 2016
@felixboehm @DeepDiver1975
check if renamed user is still valid by reapplying the ldap filter (#…
aa42d60 
…25338)
@DeepDiver1975 DeepDiver1975 mentioned this pull request Jul 4, 2016
Merged
@DeepDiver1975
Copy link
Member

DeepDiver1975 commented Jul 4, 2016 •
edited
Loading

master #25344
stable9.2: #25347

DeepDiver1975 pushed a commit that referenced this pull request Jul 4, 2016
@felixboehm @DeepDiver1975
check if renamed user is still valid by reapplying the ldap filter (#…
325776e 
…25338)
@DeepDiver1975 DeepDiver1975 mentioned this pull request Jul 4, 2016
Merged
@SergioBertolinSG
Copy link
Contributor

SergioBertolinSG commented Jul 5, 2016

Stable8.2 is affected.

@PVince81
Copy link
Contributor

PVince81 commented Jul 5, 2016

@DeepDiver1975 can you also submit a backport to 8.2 ?

@SergioBertolinSG
Copy link
Contributor

SergioBertolinSG commented Jul 5, 2016

Stable8.1 affected as well.

DeepDiver1975 pushed a commit that referenced this pull request Jul 6, 2016
@felixboehm @DeepDiver1975
[stable8.2] check if renamed user is still valid by reapplying the ld…
648afa8 
…ap filter (#25338)
DeepDiver1975 pushed a commit that referenced this pull request Jul 6, 2016
@felixboehm @DeepDiver1975
[stable8.1] check if renamed user is still valid by reapplying the ld…
19b34b5 
…ap filter (#25338)
This was referenced Jul 6, 2016
Merged
Merged
@DeepDiver1975
Copy link
Member

DeepDiver1975 commented Jul 6, 2016

backports have been prepared

@PVince81
Copy link
Contributor

PVince81 commented Jul 7, 2016

stable8.2: #25394
stable8.1: #25393

@Yvan-Masson Yvan-Masson mentioned this pull request Jul 11, 2016
Closed
DeepDiver1975 added a commit that referenced this pull request Aug 10, 2016
@DeepDiver1975
[stable8.2] check if renamed user is still valid by reapplying the ld… (
accf28a 
#25394)

* [stable8.2] check if renamed user is still valid by reapplying the ldap filter (#25338)

* Add missing filter during cleanup

* Fix another missing check
PVince81 pushed a commit that referenced this pull request Aug 11, 2016
@felixboehm
[stable8.1] check if renamed user is still valid by reapplying the ld…
fabb3fa 
…ap filter (#25338)
PVince81 pushed a commit that referenced this pull request Aug 18, 2016
@felixboehm
[stable8.1] check if renamed user is still valid by reapplying the ld…
afe9f02 
…ap filter (#25338)
@lock
Copy link

lock bot commented Aug 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@DeepDiver1975 DeepDiver1975

Labels

sev1-critical

Projects

None yet

Milestone

9.0.4

Development

Successfully merging this pull request may close these issues.

7 participants

@felixboehm @mention-bot @PVince81 @SergioBertolinSG @DeepDiver1975 @MorrisJobke