Skip to content

Conversation

@PVince81
Copy link
Contributor

@PVince81 PVince81 commented Jul 5, 2016

Makes sure that the share owner is set before entering the checks that
need it.

Partial backport of afa37d3 from

Fixes #25359 which is a regression from OC 8.2.

I will add an integration test for this to avoid future regressions.

Makes sure that the share owner is set before entering the checks that
need it.

Partial backport of afa37d3
@mention-bot
Copy link

@PVince81, thanks for your PR! By analyzing the annotation information on this pull request, we identified @rullzer, @LukasReschke and @nickvergessen to be potential reviewers

Add integration test for the use case where a group share exists and
then the same owner creates a direct share to a user in that group.
@PVince81
Copy link
Contributor Author

PVince81 commented Jul 5, 2016

Integration test added. I'll forward port it to master.

Please review @owncloud/sharing @DeepDiver1975 @georgehrke @guruz

@SergioBertolinSG
Copy link
Contributor

I'll seeing something that not sure if it correct but doesn't seems to be. After following the steps of #25359 user2 has three folders same name + (2) and (3), with different permissions. I guess user2 should have just one folder.

@PVince81
Copy link
Contributor Author

PVince81 commented Jul 6, 2016

@SergioBertolinSG this is another issue, not related to this one.

See #24575 and #25113

Internally the shares must be created in a duplicated manner to be able to unshare again. However at mount time, some logic needs to be adjusted to properly merge the shares together as it used to do in OC <= 8.2

@SergioBertolinSG
Copy link
Contributor

OK, 👍 then.

@PVince81 PVince81 merged commit 3864555 into stable9 Jul 6, 2016
@PVince81 PVince81 deleted the stable9-backportshareownerfix branch July 6, 2016 10:48
@lock
Copy link

lock bot commented Aug 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants