Skip to content

Store the shared propagator instance #25509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DeepDiver1975 merged 1 commit into from
Aug 12, 2016
Merged

Store the shared propagator instance #25509

DeepDiver1975 merged 1 commit into from
Aug 12, 2016

Conversation

@PVince81
Copy link
Contributor

@PVince81 PVince81 commented Jul 18, 2016

This instead of recreating it for every call.

Fixes #25506

Steps to reproduce are here #25506 (comment)

Note: no backport required, only happens on 9.1

@owncloud/filesystem please review

@PVince81 PVince81 added this to the 9.1.1 milestone Jul 18, 2016
@mention-bot
Copy link

mention-bot commented Jul 18, 2016

@PVince81, thanks for your PR! By analyzing the annotation information on this pull request, we identified @icewind1991, @rullzer and @schiessle to be potential reviewers

@PVince81 PVince81 mentioned this pull request Jul 18, 2016
Closed
@icewind1991
Copy link
Contributor

icewind1991 commented Jul 18, 2016

👍 looks good

@PVince81 PVince81 force-pushed the shared-cachethepropagatorinstance branch from 7c9f8c6 to 76f0ea8 Compare July 22, 2016 10:30
@PVince81
Copy link
Contributor Author

PVince81 commented Jul 22, 2016

Rebased

@PVince81 PVince81 modified the milestones: 9.2, 9.1.1 Jul 22, 2016
@PVince81
Copy link
Contributor Author

PVince81 commented Jul 22, 2016 •
edited
Loading

  • Needs backport for 9.1.1

@PVince81
Copy link
Contributor Author

PVince81 commented Aug 10, 2016

Confirmed working by a few reporters in #25506, counting as 👍

Now let's kick Jenkins

@PVince81 PVince81 force-pushed the shared-cachethepropagatorinstance branch from 76f0ea8 to 1965ac0 Compare August 10, 2016 06:36
@PVince81 PVince81 mentioned this pull request Aug 10, 2016
Merged
@PVince81
Copy link
Contributor Author

PVince81 commented Aug 10, 2016

stable9.1: #25751

@schiessle schiessle mentioned this pull request Aug 10, 2016
Merged
@PVince81
Copy link
Contributor Author

PVince81 commented Aug 11, 2016

Oh, a real failure ?

sharing.Merging shares for recipient when shared from outside with user then group and recipient renames in between

Then as "user1" gets properties of folder "merge-test-outside-groups-renamebeforesecondshare-renamed" with:

HTTP error: 404

Store the shared propagator instance
5d6784a 
This instead of recreating it for every call.
@PVince81 PVince81 force-pushed the shared-cachethepropagatorinstance branch from 1965ac0 to 5d6784a Compare August 11, 2016 19:33
@PVince81
Copy link
Contributor Author

PVince81 commented Aug 11, 2016

Hmm, test passes locally. Rebased, just in case.

@DeepDiver1975 DeepDiver1975 merged commit 3bdebb4 into master Aug 12, 2016
@DeepDiver1975 DeepDiver1975 deleted the shared-cachethepropagatorinstance branch August 12, 2016 10:07
@bjjblackbelt
Copy link

bjjblackbelt commented Aug 12, 2016

For what its worth, your patch is working for another user as well. Thanks!

@lock
Copy link

lock bot commented Aug 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

4 - To release comp:filesystem

Projects

None yet

Milestone

10.0

Development

Successfully merging this pull request may close these issues.

BadMethodCallException in scanner from cron

6 participants

@PVince81 @mention-bot @icewind1991 @bjjblackbelt @DeepDiver1975