The birthday calendar can only hold VEVENT

[DeepDiver1975]

refs owncloud/tasks#338

[mention-bot]

@DeepDiver1975, thanks for your PR! By analyzing the annotation information on this pull request, we identified @nickvergessen, @tcitworld, @stweil and @DeepDiver1975 to be potential reviewers

[raimund-schluessler]

Hm, after applying this patch I still get this response for the birthday-calendar

 <d:response>
  <d:href>/owncloud/remote.php/dav/calendars/admin/contact_birthdays/</d:href>
  <d:propstat>
   <d:prop>
    <d:displayname>Contact birthdays</d:displayname>
    <cal:calendar-description/>
    <cal:calendar-timezone/>
    <x1:calendar-order xmlns:x1="http://apple.com/ns/ical/">0</x1:calendar-order>
    <x1:calendar-color xmlns:x1="http://apple.com/ns/ical/">#FFFFCA</x1:calendar-color>
    <cal:supported-calendar-component-set>
     <cal:comp name="VEVENT"/>
     <cal:comp name="VTODO"/>
    </cal:supported-calendar-component-set>
    <d:acl>
     <d:ace>
      <d:principal>
       <d:href>/owncloud/remote.php/dav/principals/users/admin/</d:href>
      </d:principal>
      <d:grant>
       <d:privilege>
        <d:read/>
       </d:privilege>
      </d:grant>
      <d:protected/>
     </d:ace>
    </d:acl>
    <d:owner>
     <d:href>/owncloud/remote.php/dav/principals/users/admin/</d:href>
    </d:owner>
    <oc:invite/>
   </d:prop>
   <d:status>HTTP/1.1 200 OK</d:status>
  </d:propstat>
  <d:propstat>
   <d:prop>
    <oc:calendar-enabled/>
   </d:prop>
   <d:status>HTTP/1.1 404 Not Found</d:status>
  </d:propstat>
 </d:response>

Since there is still a VTODO in it, the Tasks app does still show the calendar.

[raimund-schluessler]

I also tried php occ dav:sync-birthday-calendar with no success.

Edit: After deleting the birthday-calendar and running the above command again, it is created correctly.

Can we automate this process, so that the birthday calendar is cleanly regenerated during upgrade?

[DeepDiver1975]

I will add a repair step to adjust this for existing birthday calendars

[raimund-schluessler]

Great, thanks!
👍

[PVince81]

@georgehrke second review ?

[georgehrke]

Why is this VEVENT,VTODO and not just VEvent?

[DeepDiver1975]

THX for the hint

[DeepDiver1975]

jenkins is green on this one @PVince81 @butonic merge? THX

[butonic]

👍

[thommierother]

This issue still seems to be present on 9.1.4 with a calendar created in 9.1.3 See also owncloud/tasks#378. It makes the adding of new tasks unsuccessful, at least for users who are not able to de-select "birthdays" and select the real calendar before entering a new task (>> bad navigation in UI).

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.