Skip to content

[stable9.1] Fix smb attributes stable9 1 #25733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DeepDiver1975 merged 3 commits into from
Aug 12, 2016
Merged

[stable9.1] Fix smb attributes stable9 1 #25733

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88b25ff
Fix file permissions for SMB (read-only folders will be writeable)
jvillafanez Jun 29, 2016
10d805c
Read-only folders won't be deletable
jvillafanez Jul 19, 2016
cd866f2
Added comment for the read-only behaviour for folders
jvillafanez Jul 19, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Read-only folders won't be deletable
  • Loading branch information
@jvillafanez
jvillafanez authored and Vincent Petry committed Aug 11, 2016
commit 10d805c810df2eaeaeab2730bcf16fdf4b247d89
11 changes: 11 additions & 0 deletions apps/files_external/lib/Lib/Storage/SMB.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,17 @@ public function isUpdatable($path) {
}
}

public function isDeletable($path) {
try {
$info = $this->getFileInfo($path);
return !$info->isHidden() && !$info->isReadOnly();
} catch (NotFoundException $e) {
return false;
} catch (ForbiddenException $e) {
return false;
}
}

/**
* check if smbclient is installed
*/
Expand Down