Skip to content

[stable9] Fix file permissions for SMB (read-only folders will be writeable) #25734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DeepDiver1975 merged 1 commit into from
Aug 12, 2016
Merged

[stable9] Fix file permissions for SMB (read-only folders will be writeable) #25734

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix file permissions for SMB (read-only folders will be writeable) 
Read-only folders won't be deletable
  • Loading branch information
@jvillafanez
jvillafanez authored and Vincent Petry committed Aug 11, 2016
commit aae231d4a204b1570b73e9944cf88b947113b368
13 changes: 13 additions & 0 deletions apps/files_external/lib/smb.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,19 @@ public function isReadable($path) {
}

public function isUpdatable($path) {
try {
$info = $this->getFileInfo($path);
// following windows behaviour for read-only folders: they can be written into
// (https://support.microsoft.com/en-us/kb/326549 - "cause" section)
return !$info->isHidden() && (!$info->isReadOnly() || $this->is_dir($path));
} catch (NotFoundException $e) {
return false;
} catch (ForbiddenException $e) {
return false;
}
}

public function isDeletable($path) {
try {
$info = $this->getFileInfo($path);
return !$info->isHidden() && !$info->isReadOnly();
Expand Down