25532_issue_password_update_notification_updated #25756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an IF ELSE statement to ensure that feedback is provided to the user on successfully updating a user password in settings.
|
@JackWillDavis, thanks for your PR! By analyzing the annotation information on this pull request, we identified @ringmaster, @MorrisJobke and @PVince81 to be potential reviewers |
|
|
settings/js/users/users.js
Outdated
| function (result) { | ||
| if (result.status != 'success') { | ||
| if(result.status == 'success') { | ||
| OC.Notification.showTemporary(t('admin', result.status)); |
Contributor
There was a problem hiding this comment.
This displays "success", the same string as returned by the server.
It would be better if the message would be clearer and said "Password successfully changed"
Contributor
Author
|
I wasn't sure on how advisable it was to return a hard coded message when the returned status would give an indication the event had completed successfully. Agree with your point though, shall I update? |
Contributor
|
Yes, please update |
Updated the password update success message
Contributor
Author
|
Updated now |
Contributor
|
👍 |
1 similar comment
Member
|
👍 |
Member
DeepDiver1975
pushed a commit
that referenced
this pull request
Aug 19, 2016
* Password Update Notification Added an IF ELSE statement to ensure that feedback is provided to the user on successfully updating a user password in settings. * Password Update Success Message Updated the password update success message
DeepDiver1975
pushed a commit
that referenced
this pull request
Aug 19, 2016
* Password Update Notification Added an IF ELSE statement to ensure that feedback is provided to the user on successfully updating a user password in settings. * Password Update Success Message Updated the password update success message
DeepDiver1975
pushed a commit
that referenced
this pull request
Aug 19, 2016
* Password Update Notification Added an IF ELSE statement to ensure that feedback is provided to the user on successfully updating a user password in settings. * Password Update Success Message Updated the password update success message
PVince81
pushed a commit
that referenced
this pull request
Aug 22, 2016
…11cd9864df9372098b55e [stable9.1] 25532_issue_password_update_notification_updated (#25756)
DeepDiver1975
added a commit
that referenced
this pull request
Sep 30, 2016
…25867) * Password Update Notification Added an IF ELSE statement to ensure that feedback is provided to the user on successfully updating a user password in settings. * Password Update Success Message Updated the password update success message
DeepDiver1975
added a commit
that referenced
this pull request
Sep 30, 2016
…#25868) * Password Update Notification Added an IF ELSE statement to ensure that feedback is provided to the user on successfully updating a user password in settings. * Password Update Success Message Updated the password update success message
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for: #25532
Added an IF ELSE statement to ensure that feedback is provided to the
user on successfully updating a user password in settings.
New pull request being put through as old wouldn't rebase.
FYI @DeepDiver1975