lastInsertId requires the prefix

[butonic]

otherwise we get a "sequence does not exist error" on oracle. just check all other occurences of lastInsertId.
without this files_external is broken on oracle

[mention-bot]

@butonic, thanks for your PR! By analyzing the annotation information on this pull request, we identified @icewind1991, @nickvergessen and @Xenopathic to be potential reviewers

[butonic]

cc @PVince81 because he wanted me to give him oracle

[DeepDiver1975]

Just another case where unit testing would have helped.

[PVince81]

@butonic any chance to add a quick unit test for this ? Even if it just calls the method with a single test case, just to give it a pass.

[PVince81]

👍 otherwise

[DeepDiver1975]

@butonic backport?

[butonic]

@PVince81 there are tests that cover this method: https://github.com/owncloud/core/blob/master/apps/files_external/tests/Service/DBConfigServiceTest.php#L66

But I assume that our files external tests only run on sqlite or mysql ... @DeepDiver1975 ?

I'll create backports.

[DeepDiver1975]

But I assume that our files external tests only run on sqlite or mysql ... @DeepDiver1975 ?

yes indeed - bloody hell .... let's ignore for now - @PVince81 will move this code to core anyhow within 9.2

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.