[stable9] In cases where the server dictates the link share expiration the date… #25766
Conversation
|
@DeepDiver1975, thanks for your PR! By analyzing the annotation information on this pull request, we identified @PVince81, @blizzz and @rullzer to be potential reviewers |
DeepDiver1975
changed the title
| this.model.get('linkShare').expiration = expiration; | ||
| this.model.saveLinkShare({ | ||
| expiration: moment($target.val(), 'DD-MM-YYYY').format('YYYY-MM-DD') | ||
| expiration: expiration |
There was a problem hiding this comment.
Hmm, I'd expect a successful ajax response to automatically trigger the model's update of the expiration.
But this is not true backbone so might need to do it manually in saveLinkShare after detecting success.
There was a problem hiding this comment.
this is necessary because the model itself does not change in between before and after the ajax call.
Let's say the server dictates an expiry to be 11.08.2016 and the user changes the date.
The response in the ajax will hold 11.08.2016 again and therefore not update the ui.
The user selected value will stay.
yes - a mess 😉
|
any test steps ? |
|
Doesn't seem to work, the expiration date field doesn't update |
DeepDiver1975
added
2 - Developing
3 - To Review
and removed
3 - To Review
2 - Developing
labels
|
Works now 👍 |
|
Does this need a forward port to stable9.1 and master ? |
yes |
… is not updated on consequitive changes and enable/disable actions
DeepDiver1975
force-pushed
the
fix-server-side-share-expiration-setting-stable9
branch
from
643db0d to
aedae12
Compare
|
@DeepDiver1975 please forward port to stable9.1 and master |
|
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
… is not updated on consequitive changes and enable/disable actions