[stable9] remove reference magic

[butonic]

using sth like

foreach ($options as $key => $option) {
  $option[$key] = self::setUserVars(OCP\User::getUser(), $option);
}

will replace all values in the array with a reference to the value. when you later try to copy the array and modify a value (eg to filter out passwords), expecting the original array to be left intact ... you will be disappointed

cc @PVince81 @jvillafanez @DeepDiver1975

will submit PRs up to master

[mention-bot]

@butonic, thanks for your PR! By analyzing the annotation information on this pull request, we identified @PVince81, @Xenopathic and @icewind1991 to be potential reviewers

[butonic]

marking as regression because without this wnd will faul to work when logging is enabled because we merged the trace logging. actually only the test on the admin page fails ... oh whatever

[PVince81]

do you think this could cause other regressions like, other twisted code that would expect this twisted situation ?

[butonic]

actually I am more worried what the current code does when sending the configreport. The reference magic I am removing is only used to shorten the code ...

[PVince81]

Tested with SFTP with $user var in the root path, still works fine 👍

[jvillafanez]

If it's not commented, I'd expect this to work this way 👍

[PVince81]

Retested, still works

[PVince81]

this wasn't discovered by CI and likely won't either.

A local run of ./autotest-external.sh which covers some cases didn't show any failures.

± % ./autotest-external.sh sqlite sftp-atmoz
Using database oc_autotest
Setup environment for sqlite testing ...
cp: cannot stat ‘/srv/www/htdocs/owncloud/tests/autoconfig-sqlite.php’: No such file or directory
Installing ....
The process control (PCNTL) extensions are required in case you want to interrupt long running commands - see http://php.net/manual/en/book.pcntl.php
ownCloud is not installed - only a limited number of commands are available
creating sqlite db
ownCloud was successfully installed
Testing with sqlite ...
Run only sftp-atmoz ...
The process control (PCNTL) extensions are required in case you want to interrupt long running commands - see http://php.net/manual/en/book.pcntl.php
files_external enabled
No coverage
PHPUnit 4.8.23 by Sebastian Bergmann and contributors.

Runtime:        PHP 5.5.14 with Xdebug 2.4.0
Configuration:  /srv/www/htdocs/owncloud/tests/phpunit-autotest-external.xml

...............................................................  63 / 186 ( 33%)
............................................................... 126 / 186 ( 67%)
............................................................

Time: 1.82 seconds, Memory: 32.00Mb

OK (186 tests, 682 assertions)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.