-
Notifications
You must be signed in to change notification settings - Fork 2.1k
delete calendars when users are deleted #25918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@tcitworld, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975 to be a potential reviewer |
apps/dav/lib/HookManager.php
Outdated
| $this->usersToDelete[$params['uid']] = $user; | ||
|
|
||
| $this->calendarsToDelete = $this->calDav->getCalendarsForUser('principals/users/' . $user->getUID()); | ||
| $this->addressBooksToDelete = $this->cardDav->getAddressBooksForUser('principals/users/' . $user->getUID()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to cache the books here. Just retrieve the books in the post hook.
absolutly - give it a shot ... let me know if you need support .... |
e7324e8 to
045d156
Compare
|
Must calendar shares for these also be deleted somehow ? Or is that done by a cron job that cleans up orphaned shares ? |
nice catch .... we should add this as well ... |
|
Added, but the whole doesn't work. Also, I'm waiting for #26200 to be merged. |
|
Getting list of calendars to delete is to be done in the |
|
tested - works 👍 |
|
We have orphaned calenders (or more importantly: calendar shares) which I would like to delete. It's fine with me to delete them manually from the database. Any instructions how I should do that? |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes #25912
No tests changed, maybe time to add some ?