Skip to content

Conversation

@PVince81
Copy link
Contributor

Squashed backport of #25922 to stable9.1

Please review and test @mrow4a @davitol @SergioBertolinSG

Instead of pre-rendering all multiselects with lots of group entries,
the current groups are now displayed as simple labels.
Behind the labels there is a pencil icon like for other fields.
When clicking the pencil icon, the dropdown will be spawned and will
open itself.
Upon closing of the dropdown, the label comes back with the updated
selection and the dropdown is destroyed.
@PVince81 PVince81 added this to the 9.1.1 milestone Aug 24, 2016
@mention-bot
Copy link

@PVince81, thanks for your PR! By analyzing the annotation information on this pull request, we identified @ringmaster, @icewind1991 and @tanghus to be potential reviewers

@SergioBertolinSG
Copy link
Contributor

SergioBertolinSG commented Aug 24, 2016

Works fine 👍

But I've noticed that #16041 is still there. (in master also).

@PVince81
Copy link
Contributor Author

@SergioBertolinSG yes, because nobody fixed #16041 yet

@SergioBertolinSG
Copy link
Contributor

@PVince81 I've created a PR for it #25934

@mrow4a
Copy link
Contributor

mrow4a commented Aug 24, 2016

LDAP
50000 users
2000 groups

Verified, on stable9.1 branch, it freezes my Firefox and one need to spam continue button for many seconds.

On stable9.1-users-lazydropdownwithpencil I am not experiencing the problem and it behaves similarly to what we discussed in owncloud master. It also seems to work faster than for 9.0

image

@PVince81 PVince81 merged commit a870db5 into stable9.1 Aug 24, 2016
@PVince81 PVince81 deleted the stable9.1-users-lazydropdownwithpencil branch August 24, 2016 17:36
@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants