[stable9.1] forward port smbfixes

[butonic]

Description

forward port smbfixes of #25817 to stable9.1

Related Issue

debugged at customer

Motivation and Context

Windows seems to set the hidden flag on shares of drives, eg. E: This PR fakes the visibility and forward ports the trace logging developed to find the root cause / reproduce the problem.

How Has This Been Tested?

At the customer, locally and with the testsuite. Although we should add a share that is set up as described above to automatically cover the use case.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed. We'll see about that

[mention-bot]

@butonic, thanks for your PR! By analyzing the annotation information on this pull request, we identified @blizzz, @icewind1991, @PVince81 and @Xenopathic to be potential reviewers

[PVince81]

PHP Fatal error:  Cannot declare class OC\Files\Storage\SMB, because the name is already in use in /var/lib/jenkins/workspace/owncloud-core/core/PR-25951/apps/files_external/lib/Lib/Storage/SMB.php on line 677
16:03:13 PHP Stack trace:
16:03:13 PHP Stack trace:
16:03:13 PHP   1. {main}() /usr/local/bin/phpunit:0
16:03:13 PHP   2. PHPUnit_TextUI_Command::main() /usr/local/bin/phpunit:548
16:03:13 PHP   3. PHPUnit_TextUI_Command->run() phar:///usr/local/bin/phpunit/phpunit/TextUI/Command.php:100
16:03:13 PHP   4. PHPUnit_TextUI_TestRunner->doRun() phar:///usr/local/bin/phpunit/phpunit/TextUI/Command.php:149
16:03:13 PHP   5. PHPUnit_Framework_TestSuite->run() phar:///usr/local/bin/phpunit/phpunit/TextUI/TestRunner.php:440
16:03:13 PHP   6. PHPUnit_Framework_TestCase->run() phar:///usr/local/bin/phpunit/phpunit/Framework/TestSuite.php:747
16:03:13 PHP   7. PHPUnit_Framework_TestResult->run() phar:///usr/local/bin/phpunit/phpunit/Framework/TestCase.php:724
16:03:13 PHP   8. PHPUnit_Framework_TestCase->runBare() phar:///usr/local/bin/phpunit/phpunit/Framework/TestResult.php:612
16:03:13 PHP   9. OCA\Files_External\Tests\Storage\SmbTest->setUp() phar:///usr/local/bin/phpunit/phpunit/Framework/TestCase.php:764
16:03:13 PHP  10. spl_autoload_call() /var/lib/jenkins/workspace/owncloud-core/core/PR-25951/apps/files_external/tests/Storage/SmbTest.php:52
16:03:13 PHP  11. Composer\Autoload\ClassLoader->loadClass() /var/lib/jenkins/workspace/owncloud-core/core/PR-25951/apps/files_external/tests/Storage/SmbTest.php:52
16:03:13 PHP  12. Composer\Autoload\includeFile() /var/lib/jenkins/workspace/owncloud-core/core/PR-25951/lib/composer/composer/ClassLoader.php:310

[butonic]

@DeepDiver1975 why would the result files be empty?

Test report file /var/lib/jenkins/workspace/owncloud-core/core/PR-25951@2/tests/autotest-external-results-sqlite-smb-silvershell.xml was length 0

[PVince81]

@butonic I relaunched the test

[butonic]

@PVince81 @DeepDiver1975 still empty: https://jenkins.owncloud.org/job/owncloud-core/job/core/job/PR-25951/4/testReport/junit/autotest-external-results-sqlite-smb-silvershell/xml/_empty_/

[butonic]

I think I found it ... still wrong class name ... fix incoming

[butonic]

@jvillafanez @DeepDiver1975 @PVince81 jenkins is happy

[jvillafanez]

Code looks good 👍

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.