Allow increasing permissions for share owner

[PVince81]

Description

Allow increasing permissions for share owner

In some cases, the owner of the share is also recipient through a group share. The owner must still be able to increase permissions in that situation.

Related Issue

Fixes #25542

Motivation and Context

See #25542 (comment)

How Has This Been Tested?

Manual testing in web UI + automated tests for positive and negative condition.

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

Backports required

• stable9.1

Please review @butonic @VicDeo @jvillafanez @DeepDiver1975 @owncloud/sharing

[jvillafanez]

Is this needed? I'd rather keep the 404 error code if it's documented that way.

[PVince81]

Not sure if this is documented at all... But I understand your concern.
Do you want me to revert the code to 404 not found instead of 400 bad request ?

[PVince81]

fixed

[PVince81]

@DeepDiver1975 seems we have some corruption in this executor:

Downloading https://github.com/Medium/phantomjs/releases/download/v2.1.1/phantomjs-2.1.1-linux-x86_64.tar.bz2

Saving to /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2

Receiving...

Received 2502K total.

Extracting tar contents (via spawned process)

Error extracting archive

Phantom installation failed { [Error: Command failed: 

bzip2: Compressed file ends unexpectedly;

    perhaps it is corrupted?  *Possible* reason follows.

bzip2: Inappropriate ioctl for device

    Input file = (stdin), output file = (stdout)

for the sqlite test

[PVince81]

Please review @jvillafanez @DeepDiver1975 @butonic, this fixes a sharing regression as well

[jvillafanez]

👍

[PVince81]

stable9.1: #26045

[PVince81]

stable9: #26187

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.