Skip to content

Conversation

@PVince81
Copy link
Contributor

Description

Allow upload zero sized files in the web UI.
It didn't work before because there was a check for directory uploads in browsers that don't support it, the check relied on zero file size and gave false positives when uploading files with no known mime types.

Related Issue

Fixes #19116

Motivation and Context

Because people sometimes upload multiple files and have an empty file in the list, they want it to go through too.

How Has This Been Tested?

Create two local empty files "test.txt" and "test.blubb". Upload both with drag and drop and the upload dialog.
Before: test.blubb doesn't go through
After: it does!

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Backports:

  • stable8.2
  • stable9
  • stable9.1

Please review @SergioBertolinSG @michaelstingl @VicDeo @DeepDiver1975

@PVince81 PVince81 added this to the 9.2 milestone Sep 14, 2016
@mention-bot
Copy link

@PVince81, thanks for your PR! By analyzing the annotation information on this pull request, we identified @MorrisJobke, @butonic and @luckydonald to be potential reviewers

@SergioBertolinSG
Copy link
Contributor

Works 👍

@VicDeo
Copy link
Member

VicDeo commented Sep 14, 2016

👍 tested with empty files and directories

@PVince81
Copy link
Contributor Author

I'll backport this after the releases

@PVince81
Copy link
Contributor Author

stable9.1: #26135
stable9: #26136

I think this is not critical enough for stable8.2, so I'll leave it.

LukasReschke pushed a commit to nextcloud/server that referenced this pull request Sep 26, 2016
Downstreaming of owncloud/core#26113

Signed-off-by: Lukas Reschke <[email protected]>
butonic pushed a commit that referenced this pull request Jan 18, 2017
@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uploading of 0 bytes files is not possible.

6 participants