Skip to content

Conversation

@PVince81
Copy link
Contributor

Description

Properly trigger the "stop" even from the uploader.
Also update storage stats at the end of all uploads instead of for each
upload.

Related Issue

None raised.

Motivation and Context

It's a regression from before Webdav PUT was introduced.

How Has This Been Tested?

Observe the network console.
Upload several files.
Before the fix: no call to getstoragestats.php
After the fix: one call to getstoragestats.php

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 @butonic @jvillafanez @VicDeo

Properly trigger the "stop" even from the uploader.
Also update storage stats at the end of all uploads instead of for each
upload.
@PVince81 PVince81 added this to the 9.2 milestone Sep 21, 2016
@butonic
Copy link
Member

butonic commented Sep 21, 2016

👍 nice, works in chrome on win 10

@jvillafanez
Copy link
Member

Changes look good 👍

@DeepDiver1975 DeepDiver1975 merged commit 2836455 into master Sep 21, 2016
@DeepDiver1975 DeepDiver1975 deleted the files-highlightafterupload branch September 21, 2016 16:49
butonic pushed a commit that referenced this pull request Jan 18, 2017
Properly trigger the "stop" even from the uploader.
Also update storage stats at the end of all uploads instead of for each
upload.
@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants