Kill update simulation

[PVince81]

Description

Remove all code related to simulating migration at update time.

Related Issue

None

Motivation and Context

Update migration is only useful for small databases but also slows down upgrades by creating duplicates of databases.
Admins should rather rely on backups if something went wrong. Additionally, the new updater app will eventually be extended to also make database backups (or does it do it already @VicDeo?)
On bigger setups admins complained that they forgot to pass --skip-migration-test and then the simulation started and they had to revert their huge database.

How Has This Been Tested?

Not tested yet:

• TEST: CLI upgrade
• TEST: web upgrade

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

@DeepDiver1975 @butonic @VicDeo as discussed

I thought there was more code ?

[mention-bot]

@PVince81, thanks for your PR! By analyzing the annotation information on this pull request, we identified @icewind1991, @nickvergessen and @DeepDiver1975 to be potential reviewers

[CLAassistant]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

[DeepDiver1975]

👍

[PVince81]

Hmm, should we rather deprecate --skip-migration-test and the dry run one and make them do nothing ? And then remove it later ?

Because if people have existing automation scripts with that option these will fail to update with "option does not exist".

On the other hand this directly forces admin to adjust their scripts.

Thoughts @DeepDiver1975 @butonic ?

[butonic]

A script to automate upgrades? That's as wrong as it can be. We will need to document this in the release notes anyway.

[DeepDiver1975]

On the other hand this directly forces admin to adjust their scripts.

👍

[PVince81]

Ok. I just ran this and it worked fine.

[PVince81]

Doc ticket: owncloud-archive/documentation#2640

[PVince81]

@owncloud/qa FYI in case testing scripts need to be adjusted

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.