Skip to content

Conversation

@PVince81
Copy link
Contributor

Description

Translate " and " in file summary.

Related Issue

Motivation and Context

How Has This Been Tested?

Switch the language to french or german, create a file and folder and see that the connector is in the summary translated again instead of saying " and "

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Please review @ppaysant @davitol @DeepDiver1975

@mention-bot
Copy link

@PVince81, thanks for your PR! By analyzing the annotation information on this pull request, we identified @butonic, @DeepDiver1975 and @vgezer to be potential reviewers

@PVince81 PVince81 added this to the 9.2 milestone Sep 27, 2016
@PVince81
Copy link
Contributor Author

should be backported to 9.1 where the refactoring with the template was introduced

@davitol
Copy link
Contributor

davitol commented Sep 27, 2016

👍 WFM

@ppaysant
Copy link
Contributor

Tested, works for me 👍

@DeepDiver1975 DeepDiver1975 merged commit d306e36 into master Sep 27, 2016
@DeepDiver1975 DeepDiver1975 deleted the files-translate-filesummary branch September 27, 2016 07:56
@DeepDiver1975 DeepDiver1975 self-assigned this Sep 27, 2016
@DeepDiver1975
Copy link
Member

9.1: #26222

@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants