Skip to content

Conversation

@PVince81
Copy link
Contributor

Backport of new integration tests for transfer ownership #26543 to stable9

@DeepDiver1975 @owncloud/qa

@PVince81 PVince81 added this to the 9.0.7 milestone Nov 11, 2016
@mention-bot
Copy link

@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @SergioBertolinSG, @DeepDiver1975 and @rullzer to be potential reviewers.

@PVince81
Copy link
Contributor Author

PVince81 commented Nov 14, 2016

@PVince81
Copy link
Contributor Author

well... we might be lucky that the tests still passed...

@PVince81
Copy link
Contributor Author

Uh oh... Jenkins reporting success despite error ?! @DeepDiver1975

11:51:57 --- FeatureContext has missing steps. Define them with these snippets:
11:51:57 
11:51:57     /**
11:51:57      * @Given User :arg1 deletes folder :arg2
11:51:57      */
11:51:57     public function userDeletesFolder($arg1, $arg2)
11:51:57     {
11:51:57         throw new PendingException();
11:51:57     }
11:51:57 

also I think this PR will need #26576 too

@DeepDiver1975 DeepDiver1975 self-assigned this Nov 14, 2016
@DeepDiver1975
Copy link
Member

Uh oh... Jenkins reporting success despite error ?! @DeepDiver1975

will take care ...

@PVince81
Copy link
Contributor Author

Run ./run.sh features/transfer-ownership.feature:97 on this branch, I see the exit code is still 0.
Maybe it's behat's fault. We might need to grep the test results for "undefined".

@PVince81
Copy link
Contributor Author

PVince81 commented Nov 14, 2016

@DeepDiver1975
Copy link
Member

Run ./run.sh features/transfer-ownership.feature:97 on this branch, I see the exit code is still 0.

1 here ...

@DeepDiver1975 DeepDiver1975 force-pushed the stable9-behat-transferownership branch 2 times, most recently from b7c5782 to 1b11206 Compare November 21, 2016 09:35
@PVince81
Copy link
Contributor Author

Still missing the userDeletesFolder method.

@SergioBertolinSG which PR needs backporting for that ?

Vincent Petry added 2 commits November 24, 2016 15:13
* Add transfer ownership integration tests

* Added more transfer ownership tests and OCC checks
@PVince81 PVince81 force-pushed the stable9-behat-transferownership branch from 1b11206 to e12c367 Compare November 24, 2016 14:13
@PVince81
Copy link
Contributor Author

Rebased, should hopefully fix the tests

@PVince81
Copy link
Contributor Author

So, the tests worked, can we merge this ?

@DeepDiver1975 DeepDiver1975 merged commit c334f98 into stable9 Nov 24, 2016
@DeepDiver1975 DeepDiver1975 deleted the stable9-behat-transferownership branch November 24, 2016 23:20
@DeepDiver1975
Copy link
Member

👍

@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants