Skip to content

Conversation

@SergioBertolinSG
Copy link
Contributor

Backport of #26235

Conflicts:
	build/integration/features/bootstrap/WebDav.php
	build/integration/features/favorites.feature

Conflicts:
	build/integration/features/dav-v2.feature
Conflicts:
	build/integration/features/sharing-v1.feature

Conflicts:
	build/integration/features/sharing-v1.feature
Conflicts:
	build/integration/features/webdav-related.feature
Conflicts:
	build/integration/features/bootstrap/WebDav.php
@PVince81
Copy link
Contributor

Test failed: ' /var/lib/jenkins/workspace/owncloud-core_core_PR-26666-CPCQE56ODM5DBDSTILRD55B5A6C53RQJOJT4PQVVGYUA2VOUB3WA/build/integration/features/dav-v2.feature:5`

@SergioBertolinSG
Copy link
Contributor Author

I've tried manually and if user doesn't log in previously, using cadaver he cannot see his files yet.
It answers 'Did not find a collection resource'. When the users logs in he can see it.

@SergioBertolinSG
Copy link
Contributor Author

This doesn't happen in master. The not previously logged in user can browse his files using cadaver in dav endpoint.

Conflicts:
	build/integration/features/bootstrap/WebDav.php
Conflicts:
	build/integration/features/sharing-v1.feature
@PVince81
Copy link
Contributor

in FilesPlugin::checkMove, during the test:

$source                          = (string[25]) 'files/user0/textfile0.txt';
$destination                     = (string[32]) 'files/user0/FOLDER/textfile0.txt';

when done manually with cadaver:

// by property_get
$source                          = (string[13]) 'textfile0.txt';


// by property_get
$destination                     = (string[20]) 'FOLDER/textfile0.txt';

something fishy with absolute paths vs relative paths on the new DAV endpoint.

@PVince81
Copy link
Contributor

On stable9.1 the values are the same so the test is fine.
But on stable9.1 there's a fix for MOVE on the new dav endpoint. Let me check how to backport it...

@PVince81
Copy link
Contributor

Seems some fix is here #24971 but not directly backportable because it relies on another fix.

Ok... Let's remove the dav v2 move test for now and process it separately.
I'll make a separate PR for that one.

@PVince81 PVince81 mentioned this pull request Nov 24, 2016
@PVince81
Copy link
Contributor

Removed failing test, submit separately: #26707

@PVince81 PVince81 force-pushed the stable9-integration-tests-refactoring branch from 303ffa8 to 3fc3290 Compare November 24, 2016 10:29
@PVince81
Copy link
Contributor

sharing-v1.feature:769 passes for me now on this PR, so let's hope everything else passes too

@PVince81
Copy link
Contributor

Woohoo, all green 👍

@PVince81 PVince81 merged commit 34bf725 into stable9 Nov 24, 2016
@PVince81 PVince81 deleted the stable9-integration-tests-refactoring branch November 24, 2016 14:11
@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants