Don't fetch preview images if enable_previews is set to false
#26705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PhilippSchaffrath, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer, @icewind1991 and @PVince81 to be potential reviewers. |
PVince81
reviewed
Nov 24, 2016
core/js/config.php
Outdated
| 'federatedCloudShareDoc' => \OC::$server->getURLGenerator()->linkToDocs('user-sharing-federated'), | ||
| 'allowGroupSharing' => \OC::$server->getShareManager()->allowGroupSharing() | ||
| 'allowGroupSharing' => \OC::$server->getShareManager()->allowGroupSharing(), | ||
| 'previewsEnabled' => \OC::$server->getConfig()->getSystemValue('enable_previews', true) === true, |
PVince81
reviewed
Nov 24, 2016
Contributor
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
Tested, works 👍
Please fix the tab then this is good to go
Member
|
👍 |
Contributor
|
I suggest we also backport this to 9.1, 9.0, seems this never worked correctly. |
Contributor
|
@PhilippSchaffrath please submit backport PRs for 9.1 and 9.0, thanks |
This was referenced Nov 24, 2016
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Even if
enable_previewsinconfig/config.phphas been set tofalse, the file-list and detail-view both still try to get a preview image. ThelazyLoadPreviewmethod now checks for this configuration and only renders the default mime-icons now if previews have been disabled through the configuration.Motivation and Context
See description.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
@felixheidecke