[stable9] Use the correct realm for basic authentication - fixes #23427 #26721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @SergioBertolinSG and @LukasReschke to be potential reviewers. |
This was referenced Nov 25, 2016
Contributor
Author
|
Fixes #26720 |
Contributor
Author
|
I retested fed shares in both directions and they still work. |
Contributor
Author
|
Boo... |
PVince81
force-pushed
the
stable9-fix-the-realm
branch
from
42dcef6 to
505c5c3
Compare
Contributor
Author
|
@DeepDiver1975 review ? It's your fix that I backported |
|
|
||
| namespace OCA\DAV\Connector; | ||
|
|
||
| use Sabre\DAV\Auth\Backend\AbstractBasic; |
Member
|
👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #25046 to stable9.
Please note that I had to remove one block from the conflict because we don't hate the "X-Requested-With" logic at all in OC 9.0.
Please review @DeepDiver1975 @SergioBertolinSG
I've cherry-picked the automated test from #26712 here