Skip to content

Conversation

@DeepDiver1975
Copy link
Member

…s are delivered as part of moment.js - fixes #26804

backport #26839

@DeepDiver1975 DeepDiver1975 added this to the 9.1.4 milestone Dec 20, 2016
@mention-bot
Copy link

@DeepDiver1975, thanks for your PR! By analyzing the history of the files in this pull request, we identified @luckydonald, @PVince81 and @butonic to be potential reviewers.

@DeepDiver1975
Copy link
Member Author

@PVince81 should we kill the removed strings from the translation files as well?

@PVince81
Copy link
Contributor

@DeepDiver1975 makes sense, but doesn't that happen automatically anyway ? Maybe not for backports though.

@DeepDiver1975
Copy link
Member Author

Maybe not for backports though.

yes - not for the backports ....

@DeepDiver1975 DeepDiver1975 force-pushed the stable9.1-e4498de82aa481ac65d1b3c05dfc45b15872f31e branch from 78e1c27 to 4befc32 Compare December 20, 2016 09:50
@PVince81
Copy link
Contributor

👍 still works

@PVince81 PVince81 merged commit 0a6de51 into stable9.1 Dec 21, 2016
@PVince81 PVince81 deleted the stable9.1-e4498de82aa481ac65d1b3c05dfc45b15872f31e branch December 21, 2016 13:43
@DeepDiver1975 DeepDiver1975 changed the title Just use moment to comupte the time left for the upload - translation… [stable9.1] Just use moment to comupte the time left for the upload - translation… Dec 21, 2016
@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants