Skip to content

Conversation

@tomneedham
Copy link
Contributor

Description

On the deleteUser hook, only delete addressBooks that the user owns, not ones that have been shared with them.

Motivation and Context

Right now, if you delete a user, any addressbooks shared with them are also deleted.

How Has This Been Tested?

  • In the browser
  • Unit test updated

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mention-bot
Copy link

@tomneedham, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @tcitworld and @stweil to be potential reviewers.

@tomneedham tomneedham added this to the 10.0 milestone Feb 15, 2017
@tomneedham
Copy link
Contributor Author

tomneedham commented Feb 15, 2017

  • should be backported

@PVince81
Copy link
Contributor

Makes absolute sense 👍

@tomneedham please backport

@PVince81
Copy link
Contributor

@tomneedham backport still pending

@PVince81
Copy link
Contributor

@tomneedham missing backport

@DeepDiver1975
Copy link
Member

This is already in 10 - we want it in 9.1? 9.0? @PVince81

@PVince81
Copy link
Contributor

PVince81 commented Nov 6, 2017

sounds critical enough for a backport to 9.1 at least.

@PVince81
Copy link
Contributor

PVince81 commented Jan 8, 2018

ok so, 9.1 will be EOL soon... removing backport label

@lock
Copy link

lock bot commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants