Skip to content

Fix delete user dav hook to only delete users addressbooks #27169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PVince81 merged 1 commit into from
Feb 17, 2017
Merged

Fix delete user dav hook to only delete users addressbooks #27169

PVince81 merged 1 commit into from
Feb 17, 2017
+32 −10

Conversation

@tomneedham
Copy link
Contributor

@tomneedham tomneedham commented Feb 15, 2017

Description

On the deleteUser hook, only delete addressBooks that the user owns, not ones that have been shared with them.

Motivation and Context

Right now, if you delete a user, any addressbooks shared with them are also deleted.

How Has This Been Tested?

  • In the browser
  • Unit test updated

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mention-bot
Copy link

mention-bot commented Feb 15, 2017

@tomneedham, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @tcitworld and @stweil to be potential reviewers.

@tomneedham tomneedham added this to the 10.0 milestone Feb 15, 2017
@tomneedham
Copy link
Contributor Author

tomneedham commented Feb 15, 2017 •
edited
Loading

  • should be backported

@PVince81
Copy link
Contributor

PVince81 commented Feb 17, 2017

Makes absolute sense 👍

@tomneedham please backport

@PVince81 PVince81 merged commit 6e2e13e into master Feb 17, 2017
@PVince81 PVince81 deleted the preserve-shared-addressbooks branch February 17, 2017 11:02
@MorrisJobke MorrisJobke mentioned this pull request Mar 20, 2017
Merged
@PVince81
Copy link
Contributor

PVince81 commented Mar 24, 2017

@tomneedham backport still pending

@PVince81
Copy link
Contributor

PVince81 commented Aug 15, 2017

@tomneedham missing backport

@DeepDiver1975
Copy link
Member

DeepDiver1975 commented Nov 3, 2017

This is already in 10 - we want it in 9.1? 9.0? @PVince81

@PVince81
Copy link
Contributor

PVince81 commented Nov 6, 2017

sounds critical enough for a backport to 9.1 at least.

@PVince81
Copy link
Contributor

PVince81 commented Jan 8, 2018

ok so, 9.1 will be EOL soon... removing backport label

@lock
Copy link

lock bot commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@tomneedham tomneedham

Labels

3 - To Review

Projects

None yet

Milestone

10.0

Development

Successfully merging this pull request may close these issues.

5 participants

@tomneedham @mention-bot @PVince81 @DeepDiver1975