Skip to content

Conversation

@individual-it
Copy link
Member

Description

this fixes the issue #25358 by using the advanced validation from #27257

Related Issue

#25358

Motivation and Context

see #25358

How Has This Been Tested?

function tested by karma unit tests in #27257 + manual testing
would love to have also a selenium UI test for this, cause so far we only test the function but not the behaviour of the application. If someone decide to revert this commit all tests will pass but the bug will be back.
For UI tests we need #27191 to be approved and merged.

Screenshots (if appropriate):

quota

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mention-bot
Copy link

@individual-it, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ringmaster, @PVince81 and @DeepDiver1975 to be potential reviewers.

@PVince81
Copy link
Contributor

👍 thanks

@DeepDiver1975 DeepDiver1975 merged commit 55c2054 into owncloud:master Mar 1, 2017
@individual-it individual-it deleted the fix_for_25358 branch March 1, 2017 12:45
IljaN pushed a commit that referenced this pull request Mar 1, 2017
individual-it added a commit that referenced this pull request Mar 8, 2017
@individual-it individual-it mentioned this pull request Mar 8, 2017
9 tasks
DeepDiver1975 pushed a commit that referenced this pull request Mar 8, 2017
@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants