Optimise PUT - dont check again if file exists if it is already known #27528
Conversation
|
@mrow4a, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @PVince81 and @mmattel to be potential reviewers. |
| // Node is not existing, as it was explicitely set in the cache | ||
| // Next call to getNodeForPath will create cache instance and unset the cached value | ||
| return false; | ||
| } |
|
@butonic Does the order matter or should I change the test? Not also sure why this popes out though |
|
Needs some unit tests or integration? |
| * @return bool | ||
| */ | ||
| function nodeExists($path) { | ||
| $path = trim($path, '/'); |
There was a problem hiding this comment.
my first worry was that the superclass might not support false but checking the code shows that we anyway override all methods using the cache, so this should be ok
|
Note: this only affects old endpoint PUT. Not sure about the new endpoint. A unit test would be nice. |
|
@mrow4a backport to stable10 ? |
|
@PVince81 I have no idea if this applies to new endpoint, I constantly look for optimizations for both new and old |
|
check it ? debugger, etc |
|
@mrow4a please backport if possible |
|
@PVince81 ok, will give it priority tomorrow. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This does not reduce amount of DB calls, but does not calls repetetively the same functions if it is earlier known that file does not exists, caching that information