Skip to content

Conversation

@PVince81
Copy link
Contributor

Description

Obsoleted by the market.

Related Issue

Fixes #27951

Motivation and Context

How Has This Been Tested?

Not tested yet...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

TODO

  • test

@DeepDiver1975
Copy link
Member

To make this change smaller and ready for 10.0.1 we could just force return true in getSystemConfig implementation.

@PVince81
Copy link
Contributor Author

@DeepDiver1975 or a repair step that sets it to true. We can add that after the code that auto-enables the market. I'll make a PR

@PVince81
Copy link
Contributor Author

@DeepDiver1975 PR to auto-remove the key from config.php if set #27956

@PVince81 PVince81 modified the milestones: 10.0.2, 10.0.3 May 26, 2017
@PVince81
Copy link
Contributor Author

maybe we should also auto-remove the value of "appstoreurl" if pointing at the old one... see #28025 (comment)

@PVince81 PVince81 force-pushed the remove-appstoreenabled branch from 7d52113 to 9635de4 Compare July 5, 2017 11:40
@PVince81
Copy link
Contributor Author

PVince81 commented Jul 5, 2017

Rebased.

I added 'appstoreenabled' => false to the config and the market still works.

@PVince81
Copy link
Contributor Author

PVince81 commented Jul 5, 2017

@VicDeo @DeepDiver1975 please review

Obsoleted by the market.
@DeepDiver1975 DeepDiver1975 force-pushed the remove-appstoreenabled branch from 9635de4 to 5b8794a Compare July 7, 2017 07:18
@DeepDiver1975
Copy link
Member

rebased, tests adjusted and config removed from config.sample

@DeepDiver1975 DeepDiver1975 merged commit 106a6ab into master Jul 7, 2017
@DeepDiver1975 DeepDiver1975 deleted the remove-appstoreenabled branch July 7, 2017 12:09
@DeepDiver1975
Copy link
Member

@PVince81 backport?

@PVince81
Copy link
Contributor Author

stable10: #28714

@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't install market app when "appstoreenabled" is false in config.php

3 participants