-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Remove appstoreenabled and assume true #27952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
To make this change smaller and ready for 10.0.1 we could just force return true in getSystemConfig implementation. |
|
@DeepDiver1975 or a repair step that sets it to true. We can add that after the code that auto-enables the market. I'll make a PR |
|
@DeepDiver1975 PR to auto-remove the key from config.php if set #27956 |
|
maybe we should also auto-remove the value of "appstoreurl" if pointing at the old one... see #28025 (comment) |
7d52113 to
9635de4
Compare
|
Rebased. I added |
|
@VicDeo @DeepDiver1975 please review |
Obsoleted by the market.
9635de4 to
5b8794a
Compare
|
rebased, tests adjusted and config removed from config.sample |
|
@PVince81 backport? |
|
stable10: #28714 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Obsoleted by the market.
Related Issue
Fixes #27951
Motivation and Context
How Has This Been Tested?
Not tested yet...
Screenshots (if appropriate):
Types of changes
Checklist:
TODO