Skip to content

Untangle inter app dependencies #28004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PVince81 merged 8 commits into from
Aug 30, 2017
Merged

Untangle inter app dependencies #28004

PVince81 merged 8 commits into from
Aug 30, 2017

Conversation

@butonic
Copy link
Member

@butonic butonic commented May 24, 2017 •
edited by tomneedham
Loading

fixes #26297 by

  • introducing public accept and decline share events

    • triggering them in files_sharing
    • listening to them in federatedfilesharing
    • use the existing Notifications class in federatedfilesharing which alread has the necessard methods and actually will retry sending the actions in a background job, making the whole process more robust

  • make federatedfilesharing inject the 'Add to your ownCloud' button on public pages

    • by listening for the share_link_access hook triggered by files_sharing

  • load federatedfilesharing when the filesystem is initialized

  • removing hard dependencies on federatedfilesharing in files_sharing

  • fix tests

@PVince81 @DeepDiver1975 should we use AcceptRemoteShare and DeclineRemoteShare. I am trying to think ahead because there might be accept / decline events for internal shares in the future...

@butonic butonic requested review from DeepDiver1975 and VicDeo May 24, 2017 21:59
@butonic butonic changed the title Untangle inter app dependencies [WIP] Untangle inter app dependencies May 24, 2017
@butonic butonic mentioned this pull request May 24, 2017
Closed
@butonic butonic added this to the 10.0.2 milestone May 24, 2017
@butonic
Copy link
Member Author

butonic commented May 24, 2017

Errors: 460, Failures: 1

ouch ... I'll continue on monday ... or if I really need the pain

@DeepDiver1975
Copy link
Member

DeepDiver1975 commented May 26, 2017

@PVince81 @DeepDiver1975 should we use AcceptRemoteShare and DeclineRemoteShare. I am trying to think ahead because there might be accept / decline events for internal shares in the future...

👍

@PVince81 PVince81 modified the milestones: 10.0.2, 10.0.3 May 26, 2017
@PVince81
Copy link
Contributor

PVince81 commented Jul 4, 2017

@tomneedham help finish this ?

@tomneedham tomneedham force-pushed the untangle-inter-app-dependencies branch from 8b9fcc9 to 7832c54 Compare July 4, 2017 12:33
@tomneedham
Copy link
Contributor

tomneedham commented Jul 4, 2017

Fixed some tests and rebased, let see what else JenVis throws up

@tomneedham tomneedham self-assigned this Jul 4, 2017
@tomneedham tomneedham changed the title [WIP] Untangle inter app dependencies Untangle inter app dependencies Jul 18, 2017
@tomneedham tomneedham force-pushed the untangle-inter-app-dependencies branch from 1e875aa to 0223243 Compare July 25, 2017 10:45
@tomneedham
Copy link
Contributor

tomneedham commented Jul 25, 2017

rebased

@tomneedham tomneedham force-pushed the untangle-inter-app-dependencies branch from 0223243 to 6c0a962 Compare August 3, 2017 13:49
@tomneedham
Copy link
Contributor

tomneedham commented Aug 3, 2017

rebased ⛏

@PVince81
Copy link
Contributor

PVince81 commented Aug 7, 2017

restarted CI job...

@PVince81
Copy link
Contributor

PVince81 commented Aug 7, 2017

@butonic @tomneedham can you guys review each other's commits ? Is this ready for merge if CI approves ?

@felixboehm
Copy link
Contributor

felixboehm commented Aug 9, 2017

@butonic get ready here | any help needed?

@tomneedham tomneedham force-pushed the untangle-inter-app-dependencies branch from 6c0a962 to 6503619 Compare August 29, 2017 10:27
@tomneedham tomneedham force-pushed the untangle-inter-app-dependencies branch from 6503619 to 253d7d6 Compare August 29, 2017 10:31
@tomneedham
Copy link
Contributor

tomneedham commented Aug 29, 2017

Rebased and updated tests

@tomneedham
Copy link
Contributor

tomneedham commented Aug 30, 2017

CI passed 🎉

@PVince81 PVince81 merged commit baf07a7 into master Aug 30, 2017
@PVince81 PVince81 deleted the untangle-inter-app-dependencies branch August 30, 2017 14:21
@PVince81
Copy link
Contributor

PVince81 commented Aug 30, 2017

please backport

@tomneedham tomneedham mentioned this pull request Aug 30, 2017
Merged
@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

@VicDeo VicDeo Awaiting requested review from VicDeo

Assignees

@tomneedham tomneedham

Labels

3 - To Review feature:federated-cloud-sharing feature:sharing

Projects

None yet

Milestone

10.0.3

Development

Successfully merging this pull request may close these issues.

Upgrade 9.0.3.2 -> 9.1.1.3 (CentOS) - DiscoverManager not found

6 participants

@butonic @DeepDiver1975 @PVince81 @tomneedham @felixboehm