Skip to content

Optimize PUT - Dont fetch info of not existing file #28021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PVince81 merged 2 commits into from
Aug 14, 2017
Merged

Optimize PUT - Dont fetch info of not existing file #28021

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a19d632
Dont fetch info of not existing file
mrow4a May 26, 2017
ba9d835
Do check for future file to query filecache only for future file
mrow4a Aug 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Dont fetch info of not existing file
  • Loading branch information
@mrow4a
mrow4a committed Aug 10, 2017
commit a19d6321c13cfde0a6feeb1dbd8591061d79e8e0
10 changes: 4 additions & 6 deletions apps/dav/lib/Connector/Sabre/Directory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,12 +147,10 @@ public function createFile($name, $data = null) {
$this->fileView->verifyPath($this->path, $name);

$path = $this->fileView->getAbsolutePath($this->path) . '/' . $name;
// in case the file already exists/overwriting
$info = $this->fileView->getFileInfo($this->path . '/' . $name);
if (!$info) {
// use a dummy FileInfo which is acceptable here since it will be refreshed after the put is complete
$info = new \OC\Files\FileInfo($path, null, null, [], null);
}

// use a dummy FileInfo which is acceptable here since it will be refreshed after the put is complete
$info = new \OC\Files\FileInfo($path, null, null, [], null);

$node = new \OCA\DAV\Connector\Sabre\File($this->fileView, $info);
$node->acquireLock(ILockingProvider::LOCK_SHARED);
return $node->put($data);
Expand Down