Skip to content

Fix cross-storage move info when moving between two received shares #28022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PVince81 merged 3 commits into from
Jun 26, 2017
Merged

Fix cross-storage move info when moving between two received shares #28022

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f35f3e
Fix cross-storage move info when moving between two received shares
May 26, 2017
2b29079
Trying to reproduce core#28018
SergioBertolinSG May 26, 2017
cb94e0b
Improve tests
May 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Improve tests
  • Loading branch information
Vincent Petry committed May 31, 2017
commit cb94e0beac82e6e7a7be36eca151fc74c569590a
29 changes: 10 additions & 19 deletions tests/integration/features/webdav-related-new-endpoint.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,6 @@ Feature: webdav-related-new-endpoint
When user "user0" moves new chunk file with id "chunking-42" to "/existingFile.txt"
Then User "user0" checks id of file "/existingFile.txt"


Scenario: Checking file id after a move between received shares
Given using new dav path
And user "user0" exists
Expand All @@ -554,22 +553,14 @@ Feature: webdav-related-new-endpoint
And folder "/folderA" of user "user0" is shared with user "user1"
And folder "/folderB" of user "user0" is shared with user "user1"
And user "user1" created a folder "/folderA/ONE"
And user "user1" created a folder "/folderA/ONE/TWO"
And User "user1" stores id of file "/folderA/ONE"
And User "user1" moves folder "/folderA/ONE" to "/folderB"
When user "user1" created a folder "/folderB/ONE/TWO/THREE"
And using old dav path
Then user "user1" should see following elements
| /FOLDER/ |
| /PARENT/ |
| /PARENT/parent.txt |
| /textfile0.txt |
| /textfile1.txt |
| /textfile2.txt |
| /textfile3.txt |
| /textfile4.txt |
| /folderA |
| /folderB |
| /folderB/ONE |
| /folderB/ONE/TWO |
| /folderB/ONE/TWO/THREE |
And user "user1" created a folder "/folderA/ONE/TWO"
When User "user1" moves folder "/folderA/ONE" to "/folderB/ONE"
Then as "user1" the folder "/folderA" exists
And as "user1" the folder "/folderA/ONE" does not exist
# yes, a weird bug used to make this one fail
And as "user1" the folder "/folderA/ONE/TWO" does not exist
And as "user1" the folder "/folderB/ONE" exists
And as "user1" the folder "/folderB/ONE/TWO" exists
And User "user1" checks id of file "/folderB/ONE"

21 changes: 21 additions & 0 deletions tests/integration/features/webdav-related-old-endpoint.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,3 +486,24 @@ Feature: webdav-related-old-endpoint
When As an "user0"
And Downloading file "/myChunkedFile.txt"
Then Downloaded content should be "AAAAABBBBBCCCCC"

Scenario: Checking file id after a move between received shares
Given using old dav path
And user "user0" exists
And user "user1" exists
And user "user0" created a folder "/folderA"
And user "user0" created a folder "/folderB"
And folder "/folderA" of user "user0" is shared with user "user1"
And folder "/folderB" of user "user0" is shared with user "user1"
And user "user1" created a folder "/folderA/ONE"
And User "user1" stores id of file "/folderA/ONE"
And user "user1" created a folder "/folderA/ONE/TWO"
When User "user1" moves folder "/folderA/ONE" to "/folderB/ONE"
Then as "user1" the folder "/folderA" exists
And as "user1" the folder "/folderA/ONE" does not exist
# yes, a weird bug used to make this one fail
And as "user1" the folder "/folderA/ONE/TWO" does not exist
And as "user1" the folder "/folderB/ONE" exists
And as "user1" the folder "/folderB/ONE/TWO" exists
And User "user1" checks id of file "/folderB/ONE"