Respect RFC2616 Section 5.1.2 and allow absoluteURI

[butonic]

From https://www.w3.org/Protocols/rfc2616/rfc2616-sec5.html#sec5.1.2

To allow for transition to absoluteURIs in all requests in future versions of HTTP, all HTTP/1.1 servers MUST accept the absoluteURI form in requests, even though HTTP/1.1 clients will only generate them in requests to proxies.

Currently, this happens:

{"Message":"Requested uri (http:\/\/localhost\/owncloud\/remote.php\/webdav\/) is out of base uri (\/owncloud\/remote.php\/webdav\/)","Code":0,"Trace":"
#0 \/var\/www\/owncloud\/3rdparty\/sabre\/dav\/lib\/DAV\/Server.php(1279): Sabre\\HTTP\\Request->getPath()
#1 \/var\/www\/owncloud\/3rdparty\/sabre\/dav\/lib\/DAV\/Server.php(464): Sabre\\DAV\\Server->checkPreconditions(Object(Sabre\\HTTP\\Request), Object(Sabre\\HTTP\\Response))
#2 \/var\/www\/owncloud\/3rdparty\/sabre\/dav\/lib\/DAV\/Server.php(254): Sabre\\DAV\\Server->invokeMethod(Object(Sabre\\HTTP\\Request), Object(Sabre\\HTTP\\Response))
#3 \/var\/www\/owncloud\/apps\/files\/appinfo\/remote.php(83): Sabre\\DAV\\Server->exec()
#4 \/var\/www\/owncloud\/remote.php(132): require_once('\/var\/www\/ownclo...')
#5 {main}","File":"\/var\/www\/owncloud\/3rdparty\/sabre\/http\/lib\/Request.php","Line":210}

Also see client Issue: owncloud/client#3881

Test with absolute.php (adjust $host, $user, $password and $path as necessary, only works against http )

<?php
$host = 'localhost';
$user = 'user';
$password = 'password';
$path = "http://localhost/owncloud/remote.php/dav/files/$user/welcome.txt";
#$path = "/owncloud/remote.php/dav/files/$user/welcome.txt";

$fp = fsockopen($host, 80);

fputs($fp, "GET $path HTTP/1.1\r\n");
fputs($fp, "Host: $host\r\n");
fputs($fp, "Authorization: Basic ".base64_encode("$user:$password")."\r\n");
fputs($fp, "Accept: */*\r\n");
fputs($fp, "\r\n");

$result = '';
while(!feof($fp)) {
    $result .= fgets($fp, 128);
}

fclose($fp);

echo $result;

This PR ignores the host, as the OC::$WEBROOT ignores it as well.

[DeepDiver1975]

the same applies to the old endpoint as well ....

[DeepDiver1975]

[Mon Jun 19 11:38:36 2017] Undefined index: query at /home/deepdiver/Development/ownCloud/master-autotest/apps/dav/lib/Server.php#80
[Mon Jun 19 11:38:36 2017] Undefined index: fragment at /home/deepdiver/Development/ownCloud/master-autotest/apps/dav/lib/Server.php#80

[PVince81]

shouldn't this be part of Sabre instead ?

[DeepDiver1975]

shouldn't this be part of Sabre instead ?

quite valid question .... but who will answer this :-(

[PVince81]

quite valid question .... but who will answer this :-(

the ghosts of Webdav past

submit a ticket upstream ?

[PVince81]

or maybe it's our base uri that is wrong ?

[michaelstingl]

@DeepDiver1975 any news?

[DeepDiver1975]

there is one failing test which needs attention - see https://jenkins.owncloud.org/job/owncloud-core/job/core/job/PR-28131/3/

on it ....

[DeepDiver1975]

php is killing me ... https://bugs.php.net/bug.php?id=70942

[PVince81]

classic... we had to put a workaround in Sabre URI code because of that...

[DeepDiver1975]

classic... we had to put a workaround in Sabre URI code because of that...

oh - mind pointing me to the fix?

[PVince81]

here owncloud-archive/3rdparty#285

[DeepDiver1975]

here owncloud-archive/3rdparty#285

thx

[PVince81]

localhost ?

If this is legit, please add a PHP comment to explain what and why

[DeepDiver1975]

this is to trick the parse_url function - will add comment

[PVince81]

👍

[PVince81]

does backporting make sense ? not critical afaik

[DeepDiver1975]

we need this at least in stable10 - @michaelstingl 9.1 as well?

[michaelstingl]

9.1 as well?

I've no request for 9.1.x

[michaelstingl]

Will this be in 10.0.3 release?

[DeepDiver1975]

Will this be in 10.0.3 release?

yes

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.