Skip to content

Conversation

@phil-davis
Copy link
Contributor

Description

  1. Test supplying an invalid password at login - should be taken back to login page.
  2. Test going to some page before login, being redirected to login page, login and be taken to desired page.
  3. Test supplying invalid then valid password for case (2). This test is skipped by default because it fails due to bug Login screen: entering the wrong password breaks the redirect #28129 - enable the test when the bug is fixed.

Related Issue

#27858
#28129

Motivation and Context

So far we have only tested ordinary good/easy logins. Need to cover some other scenarios.

How Has This Been Tested?

Local runs of UI tests in a VM.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


/**
* @Given I go to the personal general settings page
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOTO 😮

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some guys had a discussion about GoTo a long time ago?
https://www.cs.sjsu.edu/~mak/CS185C/KnuthStructuredProgrammingGoTo.pdf
https://www.cs.utexas.edu/users/EWD/transcriptions/EWD02xx/EWD215.html
"I am familiar with the observation that the quality of programmers is a decreasing function of the density of go to statements in the programs they produce" - Dijkstra
:)

@PVince81 PVince81 merged commit b2f91bf into master Jul 4, 2017
@PVince81 PVince81 deleted the other-page-redirect branch July 4, 2017 08:12
@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants