Allow to configure the chredentials last_check by adding minutes to database #28269
Conversation
Using last_check_timeout the administrator can change the 5 minutes period in which the password of the user is rechecked. Closes owncloud#28252
lib/private/User/Session.php
Outdated
| $now = $this->timeFacory->getTime(); | ||
| if ($lastCheck > ($now - 60 * 5)) { | ||
| $now = $this->timeFactory->getTime(); | ||
| $last_check_timeout = intval($this->config->getAppValue('last_check_timeout', 5)); |
There was a problem hiding this comment.
missing app name in getAppValue() ?
There was a problem hiding this comment.
I have no idea. I think the app name is contained in the config. This is the way I was told to use it in my other app. It works in the other app and here, too.
There was a problem hiding this comment.
Hm, obviously you are right!
Very interesting. I will update the pull request.
|
@cornelinux thanks a lot. Please backport to stable10 |
|
So you mean another PR to the branch "stable10"? |
yes, and then cherry-pick these commits over to it |
|
thx. Just did it. :-) |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
5 participants
Description
It reads the timeout for re-checking credentials from the database.
Related Issue
#28252
Motivation and Context
This causes unneccessary load on the LDAP server.
Also, when using one time passwords, the 2nd authentication after 5 minutes will not work anymore!
So we need to set this to lets say 8 hours.
How Has This Been Tested?
It has been manually tested with OC 10.0.2
Screenshots (if appropriate):
N/A
Types of changes
Checklist: