Add card id cache for use during inserting of new cards with clustered dbs

[tomneedham]

Description

When running the federation:sync-addressbook occ command on a large instance with many users and utilising a DB cluster, there is an issue in the createCard() method. It first inserts the command to oc_cards and then runs updateProperties() to create the properties but this method triggers getCardId() which does a select to the DB to get the ID of the card it just inserted - this is failing on clusters where the write has not yet synced.

In this PR I just cache the uri->id so that it can be utilised in the updateProperties method.

This should also remove 1 select to the DB per new user synchronised during the command.

CardDavBackend::
createCard()
updateProperties()
getCardId()

Related Issue

If you run the sync-addressbook command on a big instance with a DB cluster it fails repeatedly when the SELECT fails, meaning the command must be restarted numerous times.

Motivation and Context

This should work without having to restart the command >20 times.

How Has This Been Tested?

Local unit tests. 2 local servers running non-clustered DBs.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.