Skip to content

do not cache logger when running unit tests #28313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
individual-it merged 1 commit into from
Jul 10, 2017
Merged

do not cache logger when running unit tests #28313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/private/Server.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1142,7 +1142,9 @@ public function getJobList() {
* @return \OCP\ILogger
*/
public function getLogger() {
if ($this->logger === null) {
//cache the logger for performance reasons
//except when running PHPUNIT tests to make it possible to use getLogger() easily in tests
if ($this->logger === null || (defined('PHPUNIT_RUN') && PHPUNIT_RUN)) {
$this->logger = $this->query('Logger');
}
return $this->logger;
Expand Down