Do not allow slash in filename when renaming #28483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PVince81
approved these changes
Jul 25, 2017
Contributor
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
👍 looks good but Travis/Selenium seems to have trouble
Contributor
Author
|
There is a test that tries to rename "data.zip" to "lorem/txt". Actually as it turns out that used to fail because there is no folder named "lorem" to put a file called "txt" into. |
Contributor
Author
|
UI tests sorted to test the various tooltip messages that come up when various invalid things are typed in the rename text box. Hopefully all the CI will pass now. |
Contributor
Author
|
Backport to stable10 in #28490 |
Contributor
Author
|
@PVince81 do we backport stuff like this to 9.1.* ? |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the JS for the UI, do not allow the forward slash when renaming or creating a new file.
Related Issue
#28475
Motivation and Context
Trying to use relative paths like "foldera/x.txt" when renaming a file, or creating a new text file with the UI is not supposed to be a "feature" and causes various issues in the UI after such a file action.
How Has This Been Tested?
JS tests verify that "/" is disallowed by isFileNameValid.
Tried renaming and create text file in the UI to verify it really is banned now.
Types of changes
Checklist: