Skip to content

[stable10] Fix length of account search term column #28576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PVince81 merged 5 commits into from
Aug 8, 2017
+127 −2
Merged

[stable10] Fix length of account search term column #28576

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
35b4887
Migration to fix term column length
tomneedham May 26, 2017
36723bd
Extend expression builder to include character length function
tomneedham May 30, 2017
6d087b5
Use LENGTHC function on oracle for length query function
tomneedham May 30, 2017
48b63bb
Handle 4 byte database encodings, max key length 191 chars
tomneedham Jun 5, 2017
d31643b
Add test for truncating of user account search terms
tomneedham Jun 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use LENGTHC function on oracle for length query function
  • Loading branch information
@tomneedham @butonic
tomneedham authored and butonic committed Aug 7, 2017
commit 6d087b5b0d9c8afd934f7b6467ca82e92edfb5ac
9 changes: 9 additions & 0 deletions lib/private/DB/QueryBuilder/ExpressionBuilder/OCIExpressionBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,4 +160,13 @@ public function iLike($x, $y, $type = null) {
$y = $this->helper->quoteColumnName($y);
return new QueryFunction('REGEXP_LIKE('.$x.', \'^\' || REPLACE('.$y.', \'%\', \'.*\') || \'$\', \'i\')');
}

/**
* Use LENGTHC on Oracle to return multi-byte safe number of characters not bytes.
* @inheritdoc
*/
public function length($column) {
$column = $this->helper->quoteColumnName($column);
return new QueryFunction("LENGTHC({$column})");
}
}