Skip to content

Conversation

@DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Aug 3, 2017

Description

This change adds a better support and handling of a read only config file

Motivation and Context

We need to support clustered setups better - in these setups the config file is not writable

How Has This Been Tested?

  • add 'config_is_read_only' => true to config.php
  • see the changed mail settings section

Screenshots (if appropriate):

bildschirmfoto von 2017-08-03 17-23-32

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I remember this code

@DeepDiver1975 DeepDiver1975 force-pushed the better-support-of-read-only-config branch from e0bf351 to 6865237 Compare August 4, 2017 11:57
@PVince81 PVince81 merged commit 0fc4c74 into master Aug 4, 2017
@PVince81 PVince81 deleted the better-support-of-read-only-config branch August 4, 2017 19:43
@PVince81
Copy link
Contributor

PVince81 commented Aug 4, 2017

@DeepDiver1975 please backport

@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants