Test deleting file directly on storage, then download #28614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Member
|
👍 Rebasing should fix the unittests. |
jvillafanez
approved these changes
Aug 8, 2017
Downloading a file that was deleted directly on storage and is still present in oc_filecache must return 404.
PVince81
force-pushed
the
tests-delete-direct-storage-404
branch
from
802dad5 to
97f128a
Compare
Contributor
Author
|
indeed, this was due to the way I tested your fix. Rebased onto master now |
Contributor
Author
|
stable10: #28618 |
9 tasks
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downloading a file that was deleted directly on storage and is still
present in oc_filecache must return 404.
This is the integration test that matches #28598.
I tested without the fix and it fails with 503. With the fix the test passes.
@jvillafanez please review