Skip to content

Make lost password errors distinguishable #28624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DeepDiver1975 merged 2 commits into from
Aug 18, 2017
Merged

Make lost password errors distinguishable #28624

DeepDiver1975 merged 2 commits into from
Aug 18, 2017

Conversation

@butonic
Copy link
Member

@butonic butonic commented Aug 9, 2017 •
edited
Loading

  1. Make the error messages distinguishable. Allows actually debugging the problem. Using cryptic numbers would not increase security because an attacker can just look them up in the code.
  2. In written form Couldn't becomes Could not

@butonic butonic force-pushed the distinguish-lost-password-errors branch from 1b56adc to 7f872a5 Compare August 9, 2017 08:15
@butonic butonic force-pushed the distinguish-lost-password-errors branch from 7f872a5 to eb8a782 Compare August 9, 2017 08:50
@butonic butonic added this to the development milestone Aug 9, 2017
@butonic butonic self-assigned this Aug 9, 2017
@DeepDiver1975
Copy link
Member

DeepDiver1975 commented Aug 9, 2017

do these messages hit the user in the ui? needs proper analysis by @Peter-Prochaska

dercorn
dercorn approved these changes Aug 15, 2017
View reviewed changes
Copy link
Contributor

@dercorn dercorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better 👍

@PVince81
Copy link
Contributor

PVince81 commented Aug 18, 2017

@DeepDiver1975 merge or delay ? All I see is "n't" replaced with "not" and I don't see how it would be wrong to change this

@butonic
Copy link
Member Author

butonic commented Aug 18, 2017 •
edited
Loading

The exception messages now end differently.

@DeepDiver1975 DeepDiver1975 merged commit 337e978 into master Aug 18, 2017
@DeepDiver1975 DeepDiver1975 deleted the distinguish-lost-password-errors branch August 18, 2017 19:01
@DeepDiver1975
Copy link
Member

DeepDiver1975 commented Aug 18, 2017

@butonic backport?

@butonic
Copy link
Member Author

butonic commented Aug 18, 2017

yes, makes supporting 10.0.3 a little easier

DeepDiver1975 added a commit that referenced this pull request Aug 21, 2017
@DeepDiver1975
[stable10] Merge pull request #28624 from owncloud/distinguish-lost-p…
2298ef0 
…assword-errors

Make lost password errors distinguishable
This was referenced Aug 21, 2017
Closed
Merged
@DeepDiver1975
Copy link
Member

DeepDiver1975 commented Aug 21, 2017

pr open ....

@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dercorn dercorn dercorn approved these changes

@settermjd settermjd Awaiting requested review from settermjd

@peterprochaska peterprochaska Awaiting requested review from peterprochaska

Assignees

@butonic butonic

Labels

3 - To Review enhancement purple-ticket sev4-low status/STALE

Projects

None yet

Milestone

10.0.3

Development

Successfully merging this pull request may close these issues.

6 participants

@butonic @DeepDiver1975 @PVince81 @dercorn @ownclouders