Skip to content

Conversation

@PVince81
Copy link
Contributor

@PVince81 PVince81 commented Aug 9, 2017

Unreleased entries based on v10.0.2..f0b8346: git log --merges v10.0.2..stable10 --format="format:%s - %b" | grep "pull request" | cut -d" " -f4,8-

Some open issues:

  • should we continue adding the major/minor labels ?
  • removed test-related entries (unit test, integration test, etc), hope this is ok
  • seems there are still too many entries, I had the feeling that the purpose of the changelog is more to be user friendly, not developer friendly (to be discussed)

I haven't decided yet whether to use any tooling for changelogs, for now I'll continue to compile them manually.

@PVince81 PVince81 added this to the development milestone Aug 9, 2017
@PVince81
Copy link
Contributor Author

PVince81 commented Aug 9, 2017

  • TODO: convert hash links to real links. I thought Github would do that automatically

@PVince81 PVince81 mentioned this pull request Aug 9, 2017
@phil-davis
Copy link
Contributor

Agree - test infrastructure and devops-related changes are not of interest here, for viewing by end-user sysadmins that want to know what "real" features and fixes are in a release.

Also regressions that happened in master and were fixed in master before release - those commits are not needed a changelog because the bug never happened to any end-user.

@PVince81
Copy link
Contributor Author

PVince81 commented Aug 9, 2017

  • update with new merges (can also be done separately, but before tagging)

@PVince81 PVince81 added the p1-urgent Critical issue, need to consider hotfix with just that issue label Aug 11, 2017
@PVince81 PVince81 self-assigned this Aug 11, 2017
@PVince81
Copy link
Contributor Author

To avoid having to copy-paste regexps, I put it all into a script: f003f111f045e3e836ab8479c97ad5099ca33d07

The entries in question still need to be reworded and split into the "added/changed/deleted" but at least a lot of the repetitive work is not needed here.

@PVince81
Copy link
Contributor Author

@PVince81
Copy link
Contributor Author

@pmaier1 @stkjj you guys happy with the changelog format ? do we still want/need the "major/minor" prefix ?

@PVince81
Copy link
Contributor Author

Update changelog and increated version to 10.0.3 beta.

@PVince81 PVince81 force-pushed the stable10-changelog branch from 30afcd7 to 47a889d Compare August 14, 2017 19:26
@PVince81 PVince81 changed the title Add initial CHANGELOG.md Add initial CHANGELOG.md, preparing 10.0.3 beta Aug 14, 2017
@PVince81 PVince81 merged commit b6f2e2b into stable10 Aug 14, 2017
@PVince81 PVince81 deleted the stable10-changelog branch August 14, 2017 19:53
@PVince81 PVince81 mentioned this pull request Aug 15, 2017
@PVince81
Copy link
Contributor Author

PR to forward port the changelog script only to master: #28682

@pmaier1
Copy link
Contributor

pmaier1 commented Aug 15, 2017

Yay, this looks perfect and is really really helpful! 👍 👍

should we continue adding the major/minor labels ?

For me this would help as it's kind of a preselection from an engineering POV. Therefore I would of course prefer adding such labels. In the end I would leave it up to you to decide on effort/benefit ratio.

@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3 - To Review p1-urgent Critical issue, need to consider hotfix with just that issue status/STALE

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants