Skip to content

[stable10] Optimize put - dont fetch metadata for part file in checksuming #28633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PVince81 merged 1 commit into from
Aug 10, 2017
Merged

[stable10] Optimize put - dont fetch metadata for part file in checksuming #28633

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion lib/private/Files/Storage/Wrapper/Checksum.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,22 @@ private static function getChecksumsInDbFormat($path) {
return rtrim($checksumString);
}

/**
* check if the file metadata should not be fetched
* NOTE: files with a '.part' extension are ignored as well!
* prevents unfinished put requests to fetch metadata which does not exists
*
* @param string $file
* @return boolean
*/
public static function isPartialFile($file) {
if (pathinfo($file, PATHINFO_EXTENSION) === 'part') {
return true;
}

return false;
}

/**
* @param string $path
* @param string $data
Expand All @@ -168,7 +184,11 @@ public function file_put_contents($path, $data) {
* @return array
*/
public function getMetaData($path) {
$parentMetaData = $this->getWrapperStorage()->getMetaData($path);
// Check if it is partial file. Partial file metadata are only checksums
$parentMetaData = [];
if(!self::isPartialFile($path)) {
$parentMetaData = $this->getWrapperStorage()->getMetaData($path);
}
$parentMetaData['checksum'] = self::getChecksumsInDbFormat($path);

if (!isset($parentMetaData['mimetype'])) {
Expand Down