Skip to content

Conversation

@lordelix
Copy link
Contributor

Description

Fix overlapping names and "sharees" if the filename is a bit longer than usual.

Related Issue

Fixes https://github.com/owncloud/enterprise/issues/2068

How Has This Been Tested?

Visual test in latest Google Chome

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests pass.

}
.has-favorites #fileList td.filename a.name {
display: flex;
justify-content: space-between;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IE11 has a lot of bugs according to http://caniuse.com/#search=justify-content

Should we disable this one for IE11 ?

@haukman
Copy link

haukman commented Aug 24, 2017

just checked the patch:

grafik

Looks good!!

Will this be part of 10.0.3?

@PVince81
Copy link
Contributor

Needs testing in all browsers, especially considering that we're using some modern CSS technique.

And test whether resizing the browser to smaller sizes doesn't mess up.

@haukman
Copy link

haukman commented Aug 24, 2017

Correct - I tried it initially with FF and it looks fine. IE is also looking good - Chrome is still looking strange.

@lordelix
Copy link
Contributor Author

This was just a quick shot if the result comes near what is expected. I'll go into it in more detail, especially older IE support:

Chrome is still looking strange.

@haukman Screenshot, or it didn't happen!

@haukman
Copy link

haukman commented Aug 24, 2017

@felixheidecke

There you go :)

grafik

@lordelix
Copy link
Contributor Author

@haukman … I hope you did purge your cache ⚓️

@haukman
Copy link

haukman commented Aug 28, 2017

@felixheidecke: Please forgive me - you are correct: Also looking fine in Chrome!

@lordelix
Copy link
Contributor Author

I tested in IE11 as well and it does work fine.
@PVince81 should we have someone else take a look at it in all browsers?

@PVince81
Copy link
Contributor

@felixheidecke if you tested yourself I think it's fine to merge now.

@PVince81 PVince81 merged commit 20094dd into master Aug 28, 2017
@PVince81 PVince81 deleted the fh_fix_filename_overlap branch August 28, 2017 12:51
@PVince81
Copy link
Contributor

@felixheidecke please backport to stable10

@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants