Remove apostrophe from error text #28688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
individual-it
approved these changes
Aug 15, 2017
Contributor
Author
|
#28691 has an option to not even display the "cannot" sentence. |
Member
|
I would vote for this option |
Contributor
|
@phil-davis backport please |
Contributor
Author
|
Backport stable10 #28702 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not use special characters in the text saying that a file cannot be read.
Related Issue
#28684
https://github.com/owncloud/firewall/issues/309
Motivation and Context
This is a pragmatic work-around for this particular case - just get rid of the apostrophe.
How Has This Been Tested?
Block a folder with a firewall rule, share a public link to it, access the public link and try to download a file in that folder. Verify that the message is displayed OK.
Screenshots (if appropriate):
Types of changes
Checklist: