Skip to content

Conversation

@PVince81
Copy link
Contributor

Description

Fix directory mime type in trashbin list

Related Issue

Fixes #28686

Motivation and Context

How Has This Been Tested?

Manual test in web UI with deleted folder.
Before: wrong icon
After: folder icon

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Note: the reason we call mime type detector here is because trashbin doesn't store the correct mimetype in the DB due to the special ".d1234567" extension, so we redetect it in this list.

@PVince81 PVince81 added this to the development milestone Aug 16, 2017
@PVince81 PVince81 requested review from VicDeo and jvillafanez August 16, 2017 11:42
@PVince81 PVince81 self-assigned this Aug 16, 2017
@PVince81 PVince81 added the p1-urgent Critical issue, need to consider hotfix with just that issue label Aug 25, 2017
@VicDeo
Copy link
Member

VicDeo commented Aug 25, 2017

Tested. Works.

@PVince81 PVince81 merged commit 94157d6 into master Aug 25, 2017
@PVince81 PVince81 deleted the fix-trashbin-dir-icon branch August 25, 2017 14:38
@PVince81
Copy link
Contributor Author

stable10: #28803

@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3 - To Review p1-urgent Critical issue, need to consider hotfix with just that issue status/STALE

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Folder icon in trash is broken in web UI

4 participants